From: Peter Stamfest <peter@stamfest.at>
Date: Mon, 1 Sep 2014 18:36:59 +0000 (+0200)
Subject: Fix nasty off-by-one error causing access beyond allocated memory
X-Git-Tag: v1.5.0-rc1~42^2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97a156874081f43fd0575a97df16c84ec99ee358;p=thirdparty%2Frrdtool-1.x.git

Fix nasty off-by-one error causing access beyond allocated memory
---

diff --git a/src/rrd_create.c b/src/rrd_create.c
index 59c978c0..cee6c633 100644
--- a/src/rrd_create.c
+++ b/src/rrd_create.c
@@ -1506,7 +1506,7 @@ static coverage_t *add_coverage(coverage_t *current_coverage, int *coverage_arra
         if (cc->covered == next->covered) {
             cc->end = next->end;
             
-            memmove(next, next + 1, sizeof(coverage_t) * (*coverage_array_size - i - 1));
+            memmove(next, next + 1, sizeof(coverage_t) * (*coverage_array_size - i - 2));
             (*coverage_array_size)--;
 
             // re-iterate with i unchanged !!