From: Andrew Bartlett <abartlet@samba.org>
Date: Thu, 14 Mar 2024 03:55:19 +0000 (+1300)
Subject: s4-auth/kerberos: Report errors observed during smb_krb5_remove_obsolete_keytab_entries()
X-Git-Tag: tdb-1.4.11~1443
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97a23e57dc88fe6b4a851bb0e0db09a4ee9b37fb;p=thirdparty%2Fsamba.git

s4-auth/kerberos: Report errors observed during smb_krb5_remove_obsolete_keytab_entries()

Previously any errors noticed during the main loop would be ignored.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Mar 14 23:16:16 UTC 2024 on atb-devel-224
---

diff --git a/source4/auth/kerberos/kerberos_util.c b/source4/auth/kerberos/kerberos_util.c
index 30d9400bffb..d022b0dda1b 100644
--- a/source4/auth/kerberos/kerberos_util.c
+++ b/source4/auth/kerberos/kerberos_util.c
@@ -712,6 +712,7 @@ krb5_error_code smb_krb5_remove_obsolete_keytab_entries(TALLOC_CTX *mem_ctx,
 						smb_get_krb5_error_message(context,
 									   code,
 									   mem_ctx));
+		goto done;
 	}
 
 	code = 0;