From: Michael Adam <obnox@samba.org>
Date: Thu, 12 Apr 2012 15:46:02 +0000 (+0200)
Subject: s3:registry: untangle assignment from check in reg_deletevalue()
X-Git-Tag: samba-4.0.0alpha20~83
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97bf05871ad384fd53f04b92489934fef1e42d63;p=thirdparty%2Fsamba.git

s3:registry: untangle assignment from check in reg_deletevalue()

Signed-off-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index 155fc96a5ff..20ece83075e 100644
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -802,7 +802,8 @@ WERROR reg_deletevalue(struct registry_key *key, const char *name)
 		return WERR_ACCESS_DENIED;
 	}
 
-	if (!W_ERROR_IS_OK(err = fill_value_cache(key))) {
+	err = fill_value_cache(key);
+	if (!W_ERROR_IS_OK(err)) {
 		return err;
 	}