From: Jeremy Allison Date: Tue, 30 Sep 2008 20:26:41 +0000 (-0700) Subject: Fix the make test problem Karolin reported. Now rename_open_files actually works... X-Git-Tag: samba-4.0.0alpha6~769^2~228^2~83^2~31 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97d57d03640664416500efb1f1cf8e5a4a9522d8;p=thirdparty%2Fsamba.git Fix the make test problem Karolin reported. Now rename_open_files actually works correctly we must emit the change notify before we change the name, not before. Jeremy. --- diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index 6933533672e..8bfa28faeae 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -5583,10 +5583,10 @@ NTSTATUS rename_internals_fsp(connection_struct *conn, DEBUG(3,("rename_internals_fsp: succeeded doing rename on %s -> %s\n", fsp->fsp_name,newname)); - rename_open_files(conn, lck, newname); - notify_rename(conn, fsp->is_directory, fsp->fsp_name, newname); + rename_open_files(conn, lck, newname); + /* * A rename acts as a new file create w.r.t. allowing an initial delete * on close, probably because in Windows there is a new handle to the