From: Pauli <ppzgs1@gmail.com>
Date: Sun, 4 Apr 2021 07:58:32 +0000 (+1000)
Subject: test: fix coverity 1475941: resource leak
X-Git-Tag: openssl-3.0.0-alpha14~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97ef45ea135a7c88bf986a7fad5f2a9d6347f2e6;p=thirdparty%2Fopenssl.git

test: fix coverity 1475941: resource leak

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14769)
---

diff --git a/test/dhtest.c b/test/dhtest.c
index 836d800c29d..294c9e3f567 100644
--- a/test/dhtest.c
+++ b/test/dhtest.c
@@ -257,8 +257,10 @@ static int dh_computekey_range_test(void)
         goto err;
 
     if (!TEST_true(BN_set_word(priv, 1))
-        || !TEST_true(DH_set0_key(dh, NULL, priv))
-        || !TEST_true(BN_set_word(pub, 1)))
+        || !TEST_true(DH_set0_key(dh, NULL, priv)))
+        goto err;
+    priv = NULL;
+    if (!TEST_true(BN_set_word(pub, 1)))
         goto err;
 
     /* Given z = pub ^ priv mod p */
@@ -282,6 +284,7 @@ static int dh_computekey_range_test(void)
     ret = 1;
 err:
     OPENSSL_free(buf);
+    BN_free(priv);
     BN_free(pub);
     BN_free(g);
     BN_free(q);