From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 31 May 2023 22:40:44 +0000 (-0400)
Subject: Don't set a default value
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=97f33e6cd4c98e6c09de0f5442cc24fffdfa883c;p=thirdparty%2Ffreeradius-server.git

Don't set a default value
---

diff --git a/doc/antora/modules/raddb/pages/radiusd.conf.adoc b/doc/antora/modules/raddb/pages/radiusd.conf.adoc
index 3325c3f50d4..1845ffa3843 100644
--- a/doc/antora/modules/raddb/pages/radiusd.conf.adoc
+++ b/doc/antora/modules/raddb/pages/radiusd.conf.adoc
@@ -669,7 +669,7 @@ security {
 $INCLUDE clients.conf
 thread pool {
 #	num_networks = 1
-	num_workers = 0
+#	num_workers = 1
 #	openssl_async_pool_init = 64
 #	openssl_async_pool_max = 1024
 }
diff --git a/raddb/radiusd.conf.in b/raddb/radiusd.conf.in
index 59dae846064..1491405aa6f 100644
--- a/raddb/radiusd.conf.in
+++ b/raddb/radiusd.conf.in
@@ -523,10 +523,10 @@ thread pool {
 	#  non-blocking, there is no reason to run hundreds of threads
 	#  as in v3.
 	#
-	#  When set to 0 the number of workers will be set from the number
-	#  of cores available on the system.
+	#  Defaults to the number of cores available on the system, or,
+	#  1, if this cannot be determined.
 	#
-	num_workers = 0
+#	num_workers = 1
 
 	#
 	#  openssl_async_pool_init:: Controls the initial number of async
diff --git a/src/lib/server/main_config.c b/src/lib/server/main_config.c
index 6813f2dd65a..dd03814aa12 100644
--- a/src/lib/server/main_config.c
+++ b/src/lib/server/main_config.c
@@ -432,8 +432,6 @@ static int num_workers_parse(TALLOC_CTX *ctx, void *out, UNUSED void *parent, CO
 
 	memcpy(&value, out, sizeof(value));
 
-	fr_assert_msg(value != 0, "Number of workers should never be zero, verify num_workers_dflt called");
-
 	/*
 	 *	If no value is specified, try and
 	 *	discover it automatically.