From: Daniel Golle <daniel@makrotopia.org>
Date: Sun, 19 Jul 2026 01:49:33 +0000 (+0100)
Subject: rtc: pcf8563: return -EINVAL when the voltage-low flag is set
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9811c57b2e01398c6f8ba29a63d93edd4ffe6482;p=thirdparty%2Fu-boot.git

rtc: pcf8563: return -EINVAL when the voltage-low flag is set

Return a proper error code instead of a bare -1 (-EPERM) when VL
indicates the time is not reliable, matching rv3032 and the Linux
driver behaviour.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---

diff --git a/drivers/rtc/pcf8563.c b/drivers/rtc/pcf8563.c
index 83d60dc9b55..b20666e8b4a 100644
--- a/drivers/rtc/pcf8563.c
+++ b/drivers/rtc/pcf8563.c
@@ -16,6 +16,7 @@
 #include <log.h>
 #include <rtc.h>
 #include <i2c.h>
+#include <linux/errno.h>
 
 #if !CONFIG_IS_ENABLED(DM_RTC)
 static uchar rtc_read  (uchar reg);
@@ -144,7 +145,7 @@ static int pcf8563_rtc_get(struct udevice *dev, struct rtc_time *tmp)
 
 	if (sec & 0x80) {
 		puts("### Warning: RTC Low Voltage - date/time not reliable\n");
-		rel = -1;
+		rel = -EINVAL;
 	}
 
 	tmp->tm_sec = bcd2bin(sec & 0x7F);