From: Bart Van Assche <bvanassche@acm.org>
Date: Sun, 27 Jan 2013 10:56:04 +0000 (+0000)
Subject: drd: Avoid that Coverity complains about a dead assignment
X-Git-Tag: svn/VALGRIND_3_9_0~411
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9816dee90302bf473dffe9e2e566678fa25dd609;p=thirdparty%2Fvalgrind.git

drd: Avoid that Coverity complains about a dead assignment

Thanks to Florian for reporting this.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13270
---

diff --git a/drd/drd_cond.c b/drd/drd_cond.c
index 23d7c8e823..5f4b3fa2b7 100644
--- a/drd/drd_cond.c
+++ b/drd/drd_cond.c
@@ -152,8 +152,7 @@ void DRD_(cond_pre_init)(const Addr cond)
 
    p = DRD_(cond_get)(cond);
 
-   if (p)
-   {
+   if (p) {
       CondErrInfo cei = { .tid = DRD_(thread_get_running_tid)(), .cond = cond };
       VG_(maybe_record_error)(VG_(get_running_tid)(),
                               CondErr,
@@ -162,7 +161,7 @@ void DRD_(cond_pre_init)(const Addr cond)
                               &cei);
    }
 
-   p = cond_get_or_allocate(cond);
+   cond_get_or_allocate(cond);
 }
 
 /** Called after pthread_cond_destroy(). */