From: Sven Kube <mail@sven-kube.de>
Date: Wed, 30 Jul 2025 10:26:13 +0000 (+0200)
Subject: resource_channels.c: Don't call ast_channel_get_by_name on empty optional arguments
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9820a622639d4f691e61b063c9128916487d8cad;p=thirdparty%2Fasterisk.git

resource_channels.c: Don't call ast_channel_get_by_name on empty optional arguments

`ast_ari_channels_create` and `ast_ari_channels_dial` called the
`ast_channel_get_by_name` function with optional arguments. Since
8f1982c4d6, this function logs an error for empty channel names.
This commit adds checks for empty optional arguments that are used
to call `ast_channel_get_by_name` to prevent these error logs.
---

diff --git a/res/ari/resource_channels.c b/res/ari/resource_channels.c
index 1aa83165ca..dcedae1880 100644
--- a/res/ari/resource_channels.c
+++ b/res/ari/resource_channels.c
@@ -1790,7 +1790,7 @@ void ast_ari_channels_create(struct ast_variable *headers,
 	char *stuff;
 	int cause;
 	struct ast_format_cap *request_cap;
-	struct ast_channel *originator;
+	struct ast_channel *originator = NULL;
 
 	/* Parse any query parameters out of the body parameter */
 	if (args->variables) {
@@ -1850,7 +1850,10 @@ void ast_ari_channels_create(struct ast_variable *headers,
 		return;
 	}
 
-	originator = ast_channel_get_by_name(args->originator);
+	if (!ast_strlen_zero(args->originator)) {
+		originator = ast_channel_get_by_name(args->originator);
+	}
+
 	if (originator) {
 		request_cap = ao2_bump(ast_channel_nativeformats(originator));
 		if (!ast_strlen_zero(args->app)) {
@@ -1952,7 +1955,9 @@ void ast_ari_channels_dial(struct ast_variable *headers,
 		return;
 	}
 
-	caller = ast_channel_get_by_name(args->caller);
+	if (!ast_strlen_zero(args->caller)) {
+		caller = ast_channel_get_by_name(args->caller);
+	}
 
 	callee = ast_channel_get_by_name(args->channel_id);
 	if (!callee) {