From: Björn Jacke Date: Tue, 22 Dec 2020 16:23:16 +0000 (+0100) Subject: dnsupdates: clean up all RRSets and not only type A X-Git-Tag: samba-4.14.0rc1~171 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=985042d391e8124b157f21a6041ff9e17188483a;p=thirdparty%2Fsamba.git dnsupdates: clean up all RRSets and not only type A BUG: https://bugzilla.samba.org/show_bug.cgi?id=13706 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14244 Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett --- diff --git a/lib/addns/dnsrecord.c b/lib/addns/dnsrecord.c index 0d149373997..e6e205e6832 100644 --- a/lib/addns/dnsrecord.c +++ b/lib/addns/dnsrecord.c @@ -430,10 +430,10 @@ DNS_ERROR dns_create_update_request(TALLOC_CTX *mem_ctx, if (!ERR_DNS_IS_OK(err)) goto error; /* - * Delete any existing A records + * Delete all existing RRsets from our name */ - err = dns_create_delete_record(req, hostname, QTYPE_A, DNS_CLASS_ANY, + err = dns_create_delete_record(req, hostname, QTYPE_ANY, DNS_CLASS_ANY, &rec); if (!ERR_DNS_IS_OK(err)) goto error; diff --git a/selftest/knownfail b/selftest/knownfail index 6f9bf3e6e76..6c005d1f4de 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -396,4 +396,3 @@ ^samba.tests.ntlmdisabled.python\(ktest\).python2.ntlmdisabled.NtlmDisabledTests.test_samr_change_password\(ktest\) ^samba.tests.ntlmdisabled.python\(ad_dc_no_ntlm\).python3.ntlmdisabled.NtlmDisabledTests.test_ntlm_connection\(ad_dc_no_ntlm\) ^samba.tests.ntlmdisabled.python\(ad_dc_no_ntlm\).python2.ntlmdisabled.NtlmDisabledTests.test_ntlm_connection\(ad_dc_no_ntlm\) -^samba4.blackbox.net_ads_dns