From: Russell King (Oracle) Date: Thu, 6 Nov 2025 11:23:21 +0000 (+0000) Subject: net: stmmac: lpc18xx: use stmmac_get_phy_intf_sel() X-Git-Tag: v6.19-rc1~170^2~204^2~6 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9882f12194082a0178a025946911e677cfdcd8d8;p=thirdparty%2Fkernel%2Flinux.git net: stmmac: lpc18xx: use stmmac_get_phy_intf_sel() Use stmmac_get_phy_intf_sel() to decode the PHY interface mode to the phy_intf_sel value, and use the result to program the ethernet mode. Signed-off-by: Russell King (Oracle) Link: https://patch.msgid.link/E1vGy5J-0000000DhQD-46Ob@rmk-PC.armlinux.org.uk Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c index 895d16dc0a4b5..0f6be2a17e659 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c @@ -47,15 +47,14 @@ static int lpc18xx_dwmac_probe(struct platform_device *pdev) return PTR_ERR(reg); } - if (plat_dat->phy_interface == PHY_INTERFACE_MODE_MII) { - ethmode = PHY_INTF_SEL_GMII_MII; - } else if (plat_dat->phy_interface == PHY_INTERFACE_MODE_RMII) { - ethmode = PHY_INTF_SEL_RMII; - } else { + if (plat_dat->phy_interface != PHY_INTERFACE_MODE_MII && + plat_dat->phy_interface != PHY_INTERFACE_MODE_RMII) { dev_err(&pdev->dev, "Only MII and RMII mode supported\n"); return -EINVAL; } + ethmode = stmmac_get_phy_intf_sel(plat_dat->phy_interface); + regmap_update_bits(reg, LPC18XX_CREG_CREG6, LPC18XX_CREG_CREG6_ETHMODE_MASK, ethmode);