From: Thomas Markwalder <tmark@isc.org>
Date: Thu, 10 Feb 2022 18:05:30 +0000 (-0500)
Subject: [#95] Use auto const& on tag loops
X-Git-Tag: Kea-2.1.3~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=98c3f320654cb99daf561cfeb2685df6df523ada;p=thirdparty%2Fkea.git

[#95] Use auto const& on tag loops

modified:
    pgsql_cb_dhcp4.cc
    pgsql_cb_impl.cc
---

diff --git a/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc b/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
index 8b6cede4ae..644a4f1be6 100644
--- a/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
+++ b/src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
@@ -199,9 +199,8 @@ public:
     StampedValuePtr getGlobalParameter4(const ServerSelector& server_selector,
                                         const std::string& name) {
         StampedValueCollection parameters;
-
-        auto tags = server_selector.getTags();
-        for (auto tag : tags) {
+        auto const& tags = server_selector.getTags();
+        for (auto const& tag : tags) {
             PsqlBindArray in_bindings;
             in_bindings.addTempString(tag.get());
             in_bindings.add(name);
@@ -816,8 +815,8 @@ public:
                 in_bindings.addInet4(pool_end_address);
                 getPools(GET_POOL4_RANGE_ANY, in_bindings, pools, pool_ids);
         } else {
-            auto tags = server_selector.getTags();
-            for (auto tag : tags) {
+            auto const& tags = server_selector.getTags();
+            for (auto const& tag : tags) {
                 PsqlBindArray in_bindings;
                 in_bindings.add(tag.get());
                 in_bindings.addInet4(pool_start_address);
@@ -4311,8 +4310,8 @@ StampedValueCollection
 PgSqlConfigBackendDHCPv4::getAllGlobalParameters4(const ServerSelector& server_selector) const {
     LOG_DEBUG(pgsql_cb_logger, DBGLVL_TRACE_BASIC, PGSQL_CB_GET_ALL_GLOBAL_PARAMETERS4);
     StampedValueCollection parameters;
-    auto tags = server_selector.getTags();
-    for (auto tag : tags) {
+    auto const& tags = server_selector.getTags();
+    for (auto const& tag : tags) {
         PsqlBindArray in_bindings;
         in_bindings.addTempString(tag.get());
         impl_->getGlobalParameters(PgSqlConfigBackendDHCPv4Impl::GET_ALL_GLOBAL_PARAMETERS4,
@@ -4329,8 +4328,8 @@ PgSqlConfigBackendDHCPv4::getModifiedGlobalParameters4(const db::ServerSelector&
     LOG_DEBUG(pgsql_cb_logger, DBGLVL_TRACE_BASIC, PGSQL_CB_GET_MODIFIED_GLOBAL_PARAMETERS4)
         .arg(util::ptimeToText(modification_time));
     StampedValueCollection parameters;
-    auto tags = server_selector.getTags();
-    for (auto tag : tags) {
+    auto const& tags = server_selector.getTags();
+    for (auto const& tag : tags) {
         PsqlBindArray in_bindings;
         in_bindings.addTempString(tag.get());
         in_bindings.addTimestamp(modification_time);
diff --git a/src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.cc b/src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.cc
index d3595ce651..5e67bf744a 100644
--- a/src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.cc
+++ b/src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.cc
@@ -138,7 +138,7 @@ PgSqlConfigBackendImpl::createAuditRevision(const int index,
     /// audit entry is when there is a single server tag, i.e. "all" or explicit
     /// server name. In fact, these are the most common two cases.
     std::string tag = ServerTag::ALL;
-    auto tags = server_selector.getTags();
+    const auto& tags = server_selector.getTags();
     if (tags.size() == 1) {
         tag = tags.begin()->get();
     }
@@ -167,8 +167,8 @@ PgSqlConfigBackendImpl::getRecentAuditEntries(const int index,
                                               const boost::posix_time::ptime& modification_time,
                                               const uint64_t& modification_id,
                                               AuditEntryCollection& audit_entries) {
-    auto tags = server_selector.getTags();
-    for (auto tag : tags) {
+    auto const& tags = server_selector.getTags();
+    for (auto const& tag : tags) {
         // Create the input parameters.
         PsqlBindArray in_bindings;
         in_bindings.addTempString(tag.get());
@@ -366,8 +366,8 @@ void
 PgSqlConfigBackendImpl::getAllOptionDefs(const int index,
                                          const ServerSelector& server_selector,
                                          OptionDefContainer& option_defs) {
-    auto tags = server_selector.getTags();
-    for (auto tag : tags) {
+    auto const& tags = server_selector.getTags();
+    for (auto const& tag : tags) {
         PsqlBindArray in_bindings;
         in_bindings.addTempString(tag.get());
         getOptionDefs(index, in_bindings, option_defs);
@@ -379,8 +379,8 @@ PgSqlConfigBackendImpl::getModifiedOptionDefs(const int index,
                                               const ServerSelector& server_selector,
                                               const boost::posix_time::ptime& modification_time,
                                               OptionDefContainer& option_defs) {
-    auto tags = server_selector.getTags();
-    for (auto tag : tags) {
+    auto const& tags = server_selector.getTags();
+    for (auto const& tag : tags) {
         PsqlBindArray in_bindings;
         in_bindings.addTempString(tag.get());
         in_bindings.addTimestamp(modification_time);
@@ -585,8 +585,8 @@ PgSqlConfigBackendImpl::getAllOptions(const int index,
                                       const ServerSelector& server_selector) {
     OptionContainer options;
 
-    auto tags = server_selector.getTags();
-    for (auto tag : tags) {
+    auto const& tags = server_selector.getTags();
+    for (auto const& tag : tags) {
         PsqlBindArray in_bindings;
         in_bindings.addTempString(tag.get());
         getOptions(index, in_bindings, universe, options);
@@ -603,9 +603,9 @@ PgSqlConfigBackendImpl::getModifiedOptions(const int index,
 
     OptionContainer options;
 
-    auto tags = server_selector.getTags();
     PsqlBindArray in_bindings;
-    for (auto tag : tags) {
+    auto const& tags = server_selector.getTags();
+    for (auto const& tag : tags) {
         in_bindings.addTempString(tag.get());
         in_bindings.addTimestamp(modification_time);
         getOptions(index, in_bindings, universe, options);