From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 21 Sep 2020 16:58:37 +0000 (+0200)
Subject: virDomainSnapshotAlignDisks: remove unnecessary 'tmp' variable
X-Git-Tag: v6.8.0-rc1~32
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=98d856dcf91d5932c29d5ee8df11f34d832578fd;p=thirdparty%2Flibvirt.git

virDomainSnapshotAlignDisks: remove unnecessary 'tmp' variable

The converted string is used exactly once so we can call the conversion
without storing the result in a variable.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index aeebe2fb33..10eb584a1c 100644
--- a/src/conf/snapshot_conf.c
+++ b/src/conf/snapshot_conf.c
@@ -709,12 +709,10 @@ virDomainSnapshotAlignDisks(virDomainSnapshotDefPtr snapdef,
                    snapdisk->snapshot != default_snapshot &&
                    !(snapdisk->snapshot == VIR_DOMAIN_SNAPSHOT_LOCATION_NONE &&
                      disk_snapshot == VIR_DOMAIN_SNAPSHOT_LOCATION_NONE)) {
-            const char *tmp;
-
-            tmp = virDomainSnapshotLocationTypeToString(default_snapshot);
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("disk '%s' must use snapshot mode '%s'"),
-                           snapdisk->name, tmp);
+                           snapdisk->name,
+                           virDomainSnapshotLocationTypeToString(default_snapshot));
             return -1;
         }
         if (snapdisk->src->path &&