From: Jason Ish <jason.ish@oisf.net>
Date: Wed, 28 Jun 2023 17:06:24 +0000 (-0600)
Subject: pcap-log: close pcap_dead_handle on close
X-Git-Tag: suricata-6.0.14~81
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=98d9e6ae19a7fa6e0de3c705e8354574ffc7efb1;p=thirdparty%2Fsuricata.git

pcap-log: close pcap_dead_handle on close

Fixes leaked handle on exit.

(cherry picked from commit 8511ef5e2db4484424bc7cde058d57b8401e5005)
---

diff --git a/src/log-pcap.c b/src/log-pcap.c
index 8ac2137232..092ab8bdd4 100644
--- a/src/log-pcap.c
+++ b/src/log-pcap.c
@@ -1028,6 +1028,10 @@ static void PcapLogDataFree(PcapLogData *pl)
     SCFree(pl->filename);
     SCFree(pl->prefix);
 
+    if (pl->pcap_dead_handle) {
+        pcap_close(pl->pcap_dead_handle);
+    }
+
 #ifdef HAVE_LIBLZ4
     if (pl->compression.format == PCAP_LOG_COMPRESSION_FORMAT_LZ4) {
         SCFree(pl->compression.buffer);