From: Richard Mudgett <rmudgett@digium.com>
Date: Mon, 3 Nov 2014 17:54:20 +0000 (+0000)
Subject: res_pjsip: Add disable_tcp_switch option.
X-Git-Tag: 12.7.0-rc1~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=98e319937c0c923cfdf9970b0e6fea894e380856;p=thirdparty%2Fasterisk.git

res_pjsip: Add disable_tcp_switch option.

When a packet exceeds the MTU, pjproject will switch from UDP to TCP.  In
some circumstances (on some networks), this can cause some issues with
messages not getting sent to the correct destination - and can also cause
connections to get dropped due to quirks in pjproject deciding to
terminate TCP connections with no messages.

While fixing the routing/messaging issues is important, having a
configuration option in Asterisk that tells pjproject to not switch over
to TCP would be useful.  That way, if some glitch is discovered on some
other network/site, we can at least disable the behavior until a fix is
put into place.

AFS-197 #close

Review: https://reviewboard.asterisk.org/r/4137/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@427129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/UPGRADE.txt b/UPGRADE.txt
index 0b595d83f4..4a28e12391 100644
--- a/UPGRADE.txt
+++ b/UPGRADE.txt
@@ -28,6 +28,10 @@ PJSIP:
    OpenSSL names are available on their system for the pjsip.conf cipher
    option.
 
+ - Added the pjsip.conf system type disable_tcp_switch option.  The option
+   allows the user to disable switching from UDP to TCP transports described
+   by RFC 3261 section 18.1.1.
+
 From 12.6.0 to 12.6.1:
 - Due to the POODLE vulnerability (see 
   https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-3566), the
diff --git a/configs/pjsip.conf.sample b/configs/pjsip.conf.sample
index 51cdf2eeb1..fd602fe7c6 100644
--- a/configs/pjsip.conf.sample
+++ b/configs/pjsip.conf.sample
@@ -780,6 +780,10 @@
                                 ; should be disposed of (default: "60")
 ;threadpool_max_size=0  ; Maximum number of threads in the res_pjsip threadpool
                         ; A value of 0 indicates no maximum (default: "0")
+;disable_tcp_switch=no  ; Disable automatic switching from UDP to TCP transports
+                        ; if outgoing request is too large.
+                        ; See RFC 3261 section 18.1.1.
+                        ; (default: "no")
 ;type=  ; Must be of type system (default: "")
 
 ;==========================GLOBAL SECTION OPTIONS=========================
diff --git a/res/res_pjsip.c b/res/res_pjsip.c
index 25fda1d52a..168fed54f2 100644
--- a/res/res_pjsip.c
+++ b/res/res_pjsip.c
@@ -1136,6 +1136,13 @@
 					<synopsis>Maximum number of threads in the res_pjsip threadpool.
 					A value of 0 indicates no maximum.</synopsis>
 				</configOption>
+				<configOption name="disable_tcp_switch" default="no">
+					<synopsis>Disable automatic switching from UDP to TCP transports.</synopsis>
+					<description><para>
+						Disable automatic switching from UDP to TCP transports if outgoing
+						request is too large.  See RFC 3261 section 18.1.1.
+					</para></description>
+				</configOption>
 				<configOption name="type">
 					<synopsis>Must be of type 'system'.</synopsis>
 				</configOption>
diff --git a/res/res_pjsip/config_system.c b/res/res_pjsip/config_system.c
index 7f8da85978..4d0ab467b5 100644
--- a/res/res_pjsip/config_system.c
+++ b/res/res_pjsip/config_system.c
@@ -49,6 +49,8 @@ struct system_config {
 		/*! Maxumum number of threads in the threadpool */
 		int max_size;
 	} threadpool;
+	/*! Nonzero to disable switching from UDP to TCP transport */
+	unsigned int disable_tcp_switch;
 };
 
 static struct ast_threadpool_options sip_threadpool_options = {
@@ -95,6 +97,7 @@ static int system_apply(const struct ast_sorcery *system_sorcery, void *obj)
 
 	if (system->compactheaders) {
 		extern pj_bool_t pjsip_use_compact_form;
+
 		pjsip_use_compact_form = PJ_TRUE;
 	}
 
@@ -103,6 +106,9 @@ static int system_apply(const struct ast_sorcery *system_sorcery, void *obj)
 	sip_threadpool_options.idle_timeout = system->threadpool.idle_timeout;
 	sip_threadpool_options.max_size = system->threadpool.max_size;
 
+	pjsip_cfg()->endpt.disable_tcp_switch =
+		system->disable_tcp_switch ? PJ_TRUE : PJ_FALSE;
+
 	return 0;
 }
 
@@ -141,6 +147,8 @@ int ast_sip_initialize_system(void)
 			OPT_UINT_T, 0, FLDSET(struct system_config, threadpool.idle_timeout));
 	ast_sorcery_object_field_register(system_sorcery, "system", "threadpool_max_size", "0",
 			OPT_UINT_T, 0, FLDSET(struct system_config, threadpool.max_size));
+	ast_sorcery_object_field_register(system_sorcery, "system", "disable_tcp_switch", "no",
+			OPT_BOOL_T, 1, FLDSET(struct system_config, disable_tcp_switch));
 
 	ast_sorcery_load(system_sorcery);