From: Michael R Sweet <msweet@msweet.org>
Date: Wed, 26 Mar 2025 20:04:02 +0000 (-0400)
Subject: Fix response from Create-Xxx-Subscriptions request to include all Subscription object... 
X-Git-Tag: v2.4.12~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=98edd72f749eb96f06fa80c177cdff382471c387;p=thirdparty%2Fcups.git

Fix response from Create-Xxx-Subscriptions request to include all Subscription object attributes (Issue #1204)
---

diff --git a/CHANGES.md b/CHANGES.md
index 1e245ac0b3..5227c6f118 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -16,6 +16,8 @@ Changes in CUPS v2.4.12 (YYYY-MM-DD)
 - Fixed a recursion issue in `ippReadIO`.
 - Fixed validation of dateTime values with time zones more than UTC+11
   (Issue #1201)
+- Fixed attributes returned by the Create-Xxx-Subscriptions requests
+  (Issue #1204)
 
 
 Changes in CUPS v2.4.11 (2024-09-30)
diff --git a/scheduler/ipp.c b/scheduler/ipp.c
index 089267c868..96ed025969 100644
--- a/scheduler/ipp.c
+++ b/scheduler/ipp.c
@@ -1,7 +1,7 @@
 /*
  * IPP routines for the CUPS scheduler.
  *
- * Copyright © 2020-2024 by OpenPrinting
+ * Copyright © 2020-2025 by OpenPrinting
  * Copyright © 2007-2021 by Apple Inc.
  * Copyright © 1997-2007 by Easy Software Products, all rights reserved.
  *
@@ -6188,8 +6188,7 @@ create_subscriptions(
     }
 
     ippAddSeparator(con->response);
-    ippAddInteger(con->response, IPP_TAG_SUBSCRIPTION, IPP_TAG_INTEGER,
-                  "notify-subscription-id", sub->id);
+    copy_subscription_attrs(con, sub, /*ra*/NULL, /*exclude*/NULL);
 
     con->response->request.status.status_code = IPP_OK;