From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 11 Dec 2019 09:17:30 +0000 (+0100)
Subject: testutilsxen: Avoid double free of driver caps
X-Git-Tag: v6.0.0-rc1~213
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=98f1f4a439e05b90ff68c430916e9ae6e6793f8b;p=thirdparty%2Flibvirt.git

testutilsxen: Avoid double free of driver caps

In testXLInitDriver() a dummy driver structure is filled and it
is freed later in testXLFreeDriver(). However, it is sufficient
to unref just driver->config because that results in
libxlDriverConfigDispose() being called which unrefs
driver->config->caps. There is no need to unref it again in
testXLFreeDriver() - in fact it's undesired.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---

diff --git a/tests/testutilsxen.c b/tests/testutilsxen.c
index 75cd42ec43..b73c79581d 100644
--- a/tests/testutilsxen.c
+++ b/tests/testutilsxen.c
@@ -105,7 +105,6 @@ libxlDriverPrivatePtr testXLInitDriver(void)
 
 void testXLFreeDriver(libxlDriverPrivatePtr driver)
 {
-    virObjectUnref(driver->config->caps);
     virObjectUnref(driver->config);
     virObjectUnref(driver->xmlopt);
     virMutexDestroy(&driver->lock);