From: NeilBrown <neilb@suse.de>
Date: Wed, 21 May 2014 03:50:52 +0000 (+1000)
Subject: DDF: remove 'FIXME' comment that doesn't need fixing.
X-Git-Tag: mdadm-3.3.1~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=98fbc0ff37611260210bac0ba63dacee8d80feac;p=thirdparty%2Fmdadm.git

DDF: remove 'FIXME' comment that doesn't need fixing.

It appears this is correct, though for consistency with elsewhere
we check that pdnum is not negative.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/super-ddf.c b/super-ddf.c
index 607f1ea1..e78e1385 100644
--- a/super-ddf.c
+++ b/super-ddf.c
@@ -4403,8 +4403,9 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
 		dprintf("%s: array %u disk %u ref %08x pd %d\n",
 			__func__, inst, n_bvd,
 			be32_to_cpu(vc->phys_refnum[n_bvd]), pd);
-		if ((state & DS_INSYNC) && ! (state & DS_FAULTY)) {
-			pd = dl->pdnum; /* FIXME: is this really correct ? */
+		if ((state & DS_INSYNC) && ! (state & DS_FAULTY) &&
+		    dl->pdnum >= 0) {
+			pd = dl->pdnum;
 			vc->phys_refnum[n_bvd] = dl->disk.refnum;
 			LBA_OFFSET(ddf, vc)[n_bvd] =
 				cpu_to_be64(mdi->data_offset);