From: Laurent Bigonville <bigon@bigon.be>
Date: Mon, 15 Jun 2015 13:31:58 +0000 (+0200)
Subject: Throw a warning if we cannot open the audit socket as a session bus
X-Git-Tag: dbus-1.9.20~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=992236f1c57a7a8930e4c8aeb21f30c2d8af21d3;p=thirdparty%2Fdbus.git

Throw a warning if we cannot open the audit socket as a session bus

This will effectively print a warning when failing to open the audit
socket running as a session bus.

The call to audit_open() should succeed even if the dbus-daemon doesn't
have the CAP_AUDIT_WRITE capability.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83856
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
---

diff --git a/bus/audit.c b/bus/audit.c
index 98f7d7b73..954afa718 100644
--- a/bus/audit.c
+++ b/bus/audit.c
@@ -67,10 +67,6 @@ bus_audit_init (BusContext *context)
       if (e == EINVAL || e == EPROTONOSUPPORT || e == EAFNOSUPPORT)
         return;
 
-      /* If user bus, bail out */
-      if (e == EPERM && getuid () != 0)
-        return;
-
       bus_context_log (context, DBUS_SYSTEM_LOG_WARNING,
                        "Failed to open connection to the audit subsystem: %s",
                        _dbus_strerror (e));