From: Roy Marples <roy@marples.name>
Date: Tue, 2 Dec 2008 14:18:37 +0000 (+0000)
Subject: Save a malloc
X-Git-Tag: v5.0.0~154
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9928a3bb971477489897a50aa8ccde5a5b11c7f4;p=thirdparty%2Fdhcpcd.git

Save a malloc
---

diff --git a/configure.c b/configure.c
index 005d54c4..87b50c95 100644
--- a/configure.c
+++ b/configure.c
@@ -220,9 +220,9 @@ find_route(struct rt *rts, const struct rt *r, struct rt **lrt,
 static void
 desc_route(const char *cmd, const struct rt *rt, const char *ifname)
 {
-	char *addr;
+	char addr[sizeof("000.000.000.000") + 1];
 
-	addr = xstrdup(inet_ntoa(rt->dest));
+	strlcpy(addr, inet_ntoa(rt->dest), sizeof(addr));
 	if (rt->gate.s_addr == INADDR_ANY)
 		syslog(LOG_DEBUG, "%s: %s route to %s/%d", ifname, cmd,
 		       addr, inet_ntocidr(rt->net));
@@ -233,7 +233,6 @@ desc_route(const char *cmd, const struct rt *rt, const char *ifname)
 	else
 		syslog(LOG_DEBUG, "%s: %s route to %s/%d via %s", ifname, cmd,
 		       addr, inet_ntocidr(rt->net), inet_ntoa(rt->gate));
-	free(addr);
 }
 
 static int