From: Martin Schwenke <martin@meltin.net>
Date: Wed, 10 Oct 2018 02:35:00 +0000 (+1100)
Subject: ctdb-daemon: Return early when refusing to run an event script
X-Git-Tag: samba-4.8.8~112
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=995a75e4b65d6fbbec808bb395e5c180e55af8ca;p=thirdparty%2Fsamba.git

ctdb-daemon: Return early when refusing to run an event script

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13659

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit a3d12252fa8e0a7e900b819dec30bdb9da458254)
---

diff --git a/ctdb/server/eventscript.c b/ctdb/server/eventscript.c
index 157f6535362..1f70ef5addf 100644
--- a/ctdb/server/eventscript.c
+++ b/ctdb/server/eventscript.c
@@ -661,6 +661,7 @@ int ctdb_event_script_run(struct ctdb_context *ctdb,
 		DEBUG(DEBUG_ERR,
 		      ("Refusing to run event '%s' while in recovery\n",
 		       ctdb_eventscript_call_names[event]));
+		return -1;
 	}
 
 	state = talloc_zero(mem_ctx, struct ctdb_event_script_run_state);