From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 11 Jun 2019 13:16:09 +0000 (+0200)
Subject: qemu: domain: Fix logic bug in qemuDomainStorageSourceAccessAllow
X-Git-Tag: v5.5.0-rc1~292
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9961e7799a6943655e5a976e62e789deded576ef;p=thirdparty%2Flibvirt.git

qemu: domain: Fix logic bug in qemuDomainStorageSourceAccessAllow

In commit 76b9aba2ba6 I tried to refactor qemuDomainStorageSourceAccessAllow
but used wrong operators for adding bitwise flags.

This way the flags would result in 0 if any of them would be applied.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 4d3a8868b2..e521bd3982 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -9491,10 +9491,10 @@ qemuDomainStorageSourceAccessAllow(virQEMUDriverPtr driver,
     qemuDomainStorageSourceAccessFlags flags = QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_SKIP_REVOKE;
 
     if (readonly)
-        flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY;
+        flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY;
 
     if (!newSource)
-        flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS;
+        flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS;
 
     return qemuDomainStorageSourceAccessModify(driver, vm, elem, flags);
 }