From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Wed, 6 Dec 2017 20:38:14 +0000 (+0100)
Subject: coverity: #1425739
X-Git-Tag: lxc-2.0.10~503
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=997abfc8803c2b98f9fd646dbd96a4d7efaf58f6;p=thirdparty%2Flxc.git

coverity: #1425739

check snprintf() return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/tests/snapshot.c b/src/tests/snapshot.c
index b035096f1..1cc07cf0a 100644
--- a/src/tests/snapshot.c
+++ b/src/tests/snapshot.c
@@ -55,6 +55,10 @@ static void try_to_remove(void)
 
 int main(int argc, char *argv[])
 {
+	int i, n, ret;
+	char path[1024];
+	struct stat sb;
+	struct lxc_snapshot *s;
 	struct lxc_container *c, *c2 = NULL;
 	char *template = "busybox";
 
@@ -89,19 +93,18 @@ int main(int argc, char *argv[])
 	}
 
 	// rootfs should be ${lxcpath}${lxcname}/snaps/snap0/rootfs
-	struct stat sb;
-	int ret;
-	char path[1024];
-	snprintf(path, 1024, "%s/%s/snaps/snap0/rootfs", lxc_get_global_config_item("lxc.lxcpath"), MYNAME);
+	ret = snprintf(path, 1024, "%s/%s/snaps/snap0/rootfs", lxc_get_global_config_item("lxc.lxcpath"), MYNAME);
+	if (ret < 0 || (size_t)ret >= 1024) {
+		fprintf(stderr, "%s: %d: failed to create string\n", __FILE__, __LINE__);
+		goto err;
+	}
+
 	ret = stat(path, &sb);
 	if (ret != 0) {
 		fprintf(stderr, "%s: %d: snapshot was not actually created\n", __FILE__, __LINE__);
 		goto err;
 	}
 
-	struct lxc_snapshot *s;
-	int i, n;
-
 	n = c->snapshot_list(c, &s);
 	if (n < 1) {
 		fprintf(stderr, "%s: %d: failed listing containers\n", __FILE__, __LINE__);