From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 11 Sep 2015 17:04:31 +0000 (+0100)
Subject: No need for if
X-Git-Tag: release_3_0_10~115
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99808494a7780ac934849f640bd0c8bd4ed81bad;p=thirdparty%2Ffreeradius-server.git

No need for if

Confusing because the rest of the frees don't use a condition
---

diff --git a/src/main/pair.c b/src/main/pair.c
index 670e12206e7..c893b1ef3ed 100644
--- a/src/main/pair.c
+++ b/src/main/pair.c
@@ -95,7 +95,7 @@ int radius_compare_vps(UNUSED REQUEST *request, VALUE_PAIR *check, VALUE_PAIR *v
 			REDEBUG("Error stringifying operand for regular expression");
 
 		regex_error:
-			if (preg) talloc_free(preg);
+			talloc_free(preg);
 			talloc_free(expr);
 			talloc_free(value);
 			return -2;