From: Stefano Lattarini Date: Fri, 15 Apr 2011 18:01:58 +0000 (+0200) Subject: maintainer check: quote literal `$' in Makefile rule X-Git-Tag: v1.11.1b~28^2~1^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99847a1220b6f3212e73dca10448297f1fc15f3e;p=thirdparty%2Fautomake.git maintainer check: quote literal `$' in Makefile rule * Makefile.am (sc_tests_PATH_SEPARATOR): Escape literal `$' character in double-quoted string. Fix a bug in which the rule emitted an erroneously empty substring in its error message. --- diff --git a/ChangeLog b/ChangeLog index 6855f9af2..0ef291013 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2011-04-14 Stefano Lattarini + + maintainer check: quote literal `$' in Makefile rule + * Makefile.am (sc_tests_PATH_SEPARATOR): Escape literal `$' + character in double-quoted string. Fix a bug in which the rule + emitted an erroneously empty substring in its error message. + 2010-09-25 Stefano Lattarini Testsuite: Use `$PATH_SEPARATOR', not `:', when extending PATH. diff --git a/Makefile.am b/Makefile.am index d19d974be..de0bb735f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -413,7 +413,7 @@ sc_tests_plain_egrep_fgrep: ## Using `:' as a PATH separator is not portable. sc_tests_PATH_SEPARATOR: @if grep -E '\bPATH=.*:.*' $(srcdir)/tests/*.test ; then \ - echo "Use \`$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \ + echo "Use \`\$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \ exit 1; \ fi diff --git a/Makefile.in b/Makefile.in index 649565b01..c9a5bd926 100644 --- a/Makefile.in +++ b/Makefile.in @@ -1093,7 +1093,7 @@ sc_tests_plain_egrep_fgrep: sc_tests_PATH_SEPARATOR: @if grep -E '\bPATH=.*:.*' $(srcdir)/tests/*.test ; then \ - echo "Use \`$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \ + echo "Use \`\$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \ exit 1; \ fi