From: Peter Eisentraut <peter@eisentraut.org>
Date: Mon, 13 Apr 2026 08:59:08 +0000 (+0200)
Subject: pg_createsubscriber: Don't use MAXPGPATH
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99b726ac4894cf40957ca6bd5473d7dfb9c36a9b;p=thirdparty%2Fpostgresql.git

pg_createsubscriber: Don't use MAXPGPATH

Use dynamic allocation instead.  Using MAXPGPATH is unnecessary in new
code like this..

Discussion: https://www.postgresql.org/message-id/flat/CAEqnbaUthOQARV1dscGvB_EsqC-YfxiM6rWkVDHc%2BG%2Bf4oSUHw%40mail.gmail.com
---

diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c
index e90fce0302e..15e06e5686e 100644
--- a/src/bin/pg_basebackup/pg_createsubscriber.c
+++ b/src/bin/pg_basebackup/pg_createsubscriber.c
@@ -172,7 +172,7 @@ static pg_prng_state prng_state;
 static char *pg_ctl_path = NULL;
 static char *pg_resetwal_path = NULL;
 
-static char logdir[MAXPGPATH];	/* Subdirectory of the user specified logdir
+static char *logdir = NULL;		/* Subdirectory of the user specified logdir
 								 * where the log files are written (if
 								 * specified) */
 
@@ -982,7 +982,6 @@ make_output_dirs(const char *log_basedir)
 	struct timeval tval;
 	time_t		now;
 	struct tm	tmbuf;
-	int			len;
 
 	/* Generate timestamp */
 	gettimeofday(&tval, NULL);
@@ -997,10 +996,7 @@ make_output_dirs(const char *log_basedir)
 			 (unsigned int) (tval.tv_usec / 1000));
 
 	/* Build timestamp directory path */
-	len = snprintf(logdir, MAXPGPATH, "%s/%s", log_basedir, timestamp);
-
-	if (len >= MAXPGPATH)
-		pg_fatal("directory path for log files is too long");
+	logdir = psprintf("%s/%s", log_basedir, timestamp);
 
 	/* Create base directory (ignore if exists) */
 	if (mkdir(log_basedir, pg_dir_create_mode) < 0 && errno != EEXIST)