From: lpsolit%gmail.com <>
Date: Fri, 22 Dec 2006 04:45:41 +0000 (+0000)
Subject: Bug 91761: sanitycheck.cgi is too broadly accessible - Patch by Frédéric Buclin... 
X-Git-Tag: bugzilla-2.23.4~141
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99cbf8f5ff129558390942a759e9d872c24012c9;p=thirdparty%2Fbugzilla.git

Bug 91761: sanitycheck.cgi is too broadly accessible - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
---

diff --git a/sanitycheck.cgi b/sanitycheck.cgi
index dd9e50598c..4b25fa038a 100755
--- a/sanitycheck.cgi
+++ b/sanitycheck.cgi
@@ -79,15 +79,11 @@ my $cgi = Bugzilla->cgi;
 my $dbh = Bugzilla->dbh;
 my $template = Bugzilla->template;
 
-# Make sure the user is authorized to access sanitycheck.cgi.  Access
-# is restricted to logged-in users who have "editbugs" privileges,
-# which is a reasonable compromise between allowing all users to access
-# the script (creating the potential for denial of service attacks)
-# and restricting access to this installation's administrators (which
-# prevents users with a legitimate interest in Bugzilla integrity
-# from accessing the script).
-Bugzilla->user->in_group("editbugs")
-  || ThrowUserError("auth_failure", {group  => "editbugs",
+# Make sure the user is authorized to access sanitycheck.cgi.
+# As this script can now alter the group_control_map table, we no longer
+# let users with editbugs privs run it anymore.
+Bugzilla->user->in_group("editcomponents")
+  || ThrowUserError("auth_failure", {group  => "editcomponents",
                                      action => "run",
                                      object => "sanity_check"});