From: Michael Brown Date: Mon, 27 Jul 2015 14:15:12 +0000 (+0100) Subject: [build] Fix compiler warnings on some gcc versions X-Git-Tag: v1.20.1~770 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99d351605a965eb18f86aa8c68cb9aab9d4b5895;p=thirdparty%2Fipxe.git [build] Fix compiler warnings on some gcc versions xfer_buffer() uses intf_get_dest_op() to obtain the destination interface for xfer_deliver(), in order to check that this is the same interface which provides xfer_buffer(). The return value from intf_get_dest_op() (which contains the actual method implementing xfer_deliver()) is not used. On some gcc versions, this triggers a "value computed is not used" warning, since the explicit type cast included within the intf_get_dest_op() macro is treated as a "value computed". Fix by explicitly casting the result of intf_get_dest_op() to void. Reported-by: Matthew Helton Reported-by: James A. Peltier Signed-off-by: Michael Brown --- diff --git a/src/core/xferbuf.c b/src/core/xferbuf.c index afc72ae76..240118557 100644 --- a/src/core/xferbuf.c +++ b/src/core/xferbuf.c @@ -309,7 +309,7 @@ struct xfer_buffer * xfer_buffer ( struct interface *intf ) { /* Check that this operation is provided by the same interface * which handles xfer_deliver(). */ - intf_get_dest_op ( intf, xfer_deliver, &xfer_deliver_dest ); + ( void ) intf_get_dest_op ( intf, xfer_deliver, &xfer_deliver_dest ); if ( op && ( dest == xfer_deliver_dest ) ) { xferbuf = op ( object );