From: David Malcolm <dmalcolm@redhat.com>
Date: Thu, 13 Oct 2022 20:05:35 +0000 (-0400)
Subject: analyzer: fix ICE introduced in r13-3168 [PR107210]
X-Git-Tag: basepoints/gcc-14~3922
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99da523359e9333555585484eb3b8f854a98f1b4;p=thirdparty%2Fgcc.git

analyzer: fix ICE introduced in r13-3168 [PR107210]

gcc/analyzer/ChangeLog:
	PR analyzer/107210
	* svalue.cc (constant_svalue::maybe_fold_bits_within): Only
	attempt to extract individual bits when tree_fits_uhwi_p.

gcc/testsuite/ChangeLog:
	PR analyzer/107210
	* gfortran.dg/analyzer/pr107210.f90: New test.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
---

diff --git a/gcc/analyzer/svalue.cc b/gcc/analyzer/svalue.cc
index a0838c0f5885..4b00a81b31d0 100644
--- a/gcc/analyzer/svalue.cc
+++ b/gcc/analyzer/svalue.cc
@@ -884,7 +884,8 @@ constant_svalue::maybe_fold_bits_within (tree type,
   if (bits.m_size_in_bits == 1
       && TREE_CODE (m_cst_expr) == INTEGER_CST
       && type
-      && INTEGRAL_TYPE_P (type))
+      && INTEGRAL_TYPE_P (type)
+      && tree_fits_uhwi_p (m_cst_expr))
     {
       unsigned HOST_WIDE_INT bit = bits.m_start_bit_offset.to_uhwi ();
       unsigned HOST_WIDE_INT mask = (1 << bit);
diff --git a/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 b/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90
new file mode 100644
index 000000000000..6132db48817b
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90
@@ -0,0 +1,16 @@
+! { dg-additional-options "-O1" }
+
+subroutine check_int (j)
+  INTEGER(4) :: i, ia(5), ib(5,4), ip, ipa(:)
+  target :: ib
+  POINTER :: ip, ipa
+  logical :: l(5)
+
+  ipa=>ib(2:3,1)
+
+  l = (/ sizeof(i) == 4, sizeof(ia) == 20, sizeof(ib) == 80, &
+       sizeof(ip) == 4, sizeof(ipa) == 8 /)
+
+  if (any(.not.l)) STOP 4
+
+end subroutine check_int