From: Leon Romanovsky <leonro@mellanox.com>
Date: Wed, 27 Dec 2017 07:57:51 +0000 (+0200)
Subject: rdma: Protect dev_map_lookup from wrong input
X-Git-Tag: v4.16.0~99
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99da90326e6af8e17400a01cf48bb60606dd22a6;p=thirdparty%2Fiproute2.git

rdma: Protect dev_map_lookup from wrong input

Despite the fact that all callers to dev_map_lookup are ensuring that
there is always device name prior to call to that function, it is better
and safer to check that in the dev_map_lookup itself.

Fixes: 40df8263a0f0 ("rdma: Add dev object")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
---

diff --git a/rdma/utils.c b/rdma/utils.c
index 6ce1fd70e..bb29fa1a2 100644
--- a/rdma/utils.c
+++ b/rdma/utils.c
@@ -253,6 +253,9 @@ struct dev_map *dev_map_lookup(struct rd *rd, bool allow_port_index)
 	char *dev_name;
 	char *slash;
 
+	if (rd_no_arg(rd))
+		return NULL;
+
 	dev_name = strdup(rd_argv(rd));
 	if (allow_port_index) {
 		slash = strrchr(dev_name, '/');