From: Yann Collet Date: Fri, 11 May 2018 02:48:09 +0000 (-0700) Subject: fixed wrong assertion X-Git-Tag: v1.3.5~3^2~55^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99ddca43a6252369c3ad062e906c5d4f50b74f3c;p=thirdparty%2Fzstd.git fixed wrong assertion base can actually overflow --- diff --git a/lib/compress/zstd_compress.c b/lib/compress/zstd_compress.c index 58daf5d0c..3a45d58dc 100644 --- a/lib/compress/zstd_compress.c +++ b/lib/compress/zstd_compress.c @@ -2003,7 +2003,6 @@ static size_t ZSTD_compressBlock_internal(ZSTD_CCtx* zc, { const BYTE* const base = ms->window.base; const BYTE* const istart = (const BYTE*)src; const U32 current = (U32)(istart-base); - assert(istart >= base); if (sizeof(ptrdiff_t)==8) assert(istart - base < (ptrdiff_t)(U32)(-1)); /* ensure no overflow */ if (current > ms->nextToUpdate + 384) ms->nextToUpdate = current - MIN(192, (U32)(current - ms->nextToUpdate - 384));