From: Paul Floyd Date: Mon, 9 Jan 2023 22:57:01 +0000 (+0100) Subject: Cleanup warnings X-Git-Tag: VALGRIND_3_21_0~232 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99dfad28a582352e8a38a5ec76554810f625d1bf;p=thirdparty%2Fvalgrind.git Cleanup warnings Now no warnings on Fedora 36 For a short while --- diff --git a/configure.ac b/configure.ac index cffb22774b..206f54d61f 100755 --- a/configure.ac +++ b/configure.ac @@ -2541,6 +2541,7 @@ AC_GCC_WARNING_SUBST_NO([nonnull], [FLAG_W_NO_NONNULL]) AC_GCC_WARNING_SUBST_NO([overflow], [FLAG_W_NO_OVERFLOW]) AC_GCC_WARNING_SUBST_NO([pointer-sign], [FLAG_W_NO_POINTER_SIGN]) AC_GCC_WARNING_SUBST_NO([uninitialized], [FLAG_W_NO_UNINITIALIZED]) +AC_GCC_WARNING_SUBST_NO([maybe-uninitialized], [FLAG_W_NO_MAYBE_UNINITIALIZED]) AC_GCC_WARNING_SUBST_NO([unused-function], [FLAG_W_NO_UNUSED_FUNCTION]) AC_GCC_WARNING_SUBST_NO([static-local-in-inline], [FLAG_W_NO_STATIC_LOCAL_IN_INLINE]) AC_GCC_WARNING_SUBST_NO([mismatched-new-delete], [FLAG_W_NO_MISMATCHED_NEW_DELETE]) @@ -2549,6 +2550,11 @@ AC_GCC_WARNING_SUBST_NO([expansion-to-defined], [FLAG_W_NO_EXPANSION_TO_DEFINED] AC_GCC_WARNING_SUBST_NO([unused-but-set-variable], [FLAG_W_NO_UNUSED_BUT_SET_VARIABLE]) AC_GCC_WARNING_SUBST_NO([non-power-of-two-alignment], [FLAG_W_NO_NON_POWER_OF_TWO_ALIGNMENT]) AC_GCC_WARNING_SUBST_NO([sign-compare], [FLAG_W_NO_SIGN_COMPARE]) +AC_GCC_WARNING_SUBST_NO([stringop-overflow], [FLAG_W_NO_STRINGOP_OVERFLOW]) +AC_GCC_WARNING_SUBST_NO([stringop-overread], [FLAG_W_NO_STRINGOP_OVERREAD]) +AC_GCC_WARNING_SUBST_NO([format-overflow], [FLAG_W_NO_FORMAT_OVERFLOW]) +AC_GCC_WARNING_SUBST_NO([use-after-free], [FLAG_W_NO_USE_AFTER_FREE]) +AC_GCC_WARNING_SUBST_NO([free-nonheap-object], [FLAG_W_NO_FREE_NONHEAP_OBJECT]) AC_GCC_WARNING_SUBST([write-strings], [FLAG_W_WRITE_STRINGS]) AC_GCC_WARNING_SUBST([empty-body], [FLAG_W_EMPTY_BODY]) diff --git a/drd/tests/thread_name.c b/drd/tests/thread_name.c index 98c7bb8a3f..3b22e852e7 100644 --- a/drd/tests/thread_name.c +++ b/drd/tests/thread_name.c @@ -20,7 +20,7 @@ static void* thread_func(void* argp) { const int thread_num = (ptrdiff_t)(argp); pthread_mutex_t invalid_mutex; - char thread_name[32]; + char thread_name[34]; snprintf(thread_name, sizeof(thread_name), "thread_func instance %d", thread_num + 1); diff --git a/memcheck/tests/Makefile.am b/memcheck/tests/Makefile.am index 53483e55cb..c382af5e07 100644 --- a/memcheck/tests/Makefile.am +++ b/memcheck/tests/Makefile.am @@ -476,6 +476,18 @@ cdebug_zlib_gnu_SOURCES = cdebug.c cdebug_zlib_gnu_CFLAGS = $(AM_CFLAGS) -g -gz=zlib-gnu @FLAG_W_NO_UNINITIALIZED@ endif +if HAVE_ALIGNED_CXX_ALLOC +check_PROGRAMS += cxx17_aligned_new +endif + +if HAVE_PTHREAD_BARRIER +check_PROGRAMS += reach_thread_register +endif + +if HAVE_FSIZED_DEALLOCATION +check_PROGRAMS += sized_delete +endif + if HAVE_GNU_STPNCPY check_PROGRAMS += stpncpy endif @@ -484,10 +496,6 @@ if HAVE_PTHREAD_SETNAME_NP check_PROGRAMS += threadname endif -if HAVE_PTHREAD_BARRIER -check_PROGRAMS += reach_thread_register -endif - AM_CFLAGS += $(AM_FLAG_M3264_PRI) AM_CXXFLAGS += $(AM_FLAG_M3264_PRI) @@ -502,15 +510,16 @@ else atomic_incs_CFLAGS = $(AM_CFLAGS) endif +badpoll_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_STRINGOP_OVERFLOW@ +badrw_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ +big_blocks_freed_list_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ + if VGCONF_OS_IS_SOLARIS buflen_check_LDADD = -lsocket -lnsl endif leak_cpp_interior_SOURCES = leak_cpp_interior.cpp -demangle_SOURCES = demangle.cpp -demangle_rust_SOURCES = demangle-rust.c - # Suppress various gcc warnings which are correct, but for things # we are actually testing for at runtime. accounting_CFLAGS = $(AM_CFLAGS) -Wno-alloc-size-larger-than @@ -525,6 +534,15 @@ big_debuginfo_symbol_SOURCES = big_debuginfo_symbol.cpp big_debuginfo_symbol_CXXFLAGS = $(AM_CXXFLAGS) -std=c++0x bug340392_CFLAGS = $(AM_CFLAGS) -O3 -Wno-maybe-uninitialized + +if HAVE_ALIGNED_CXX_ALLOC +cxx17_aligned_new_SOURCES = cxx17_aligned_new.cpp +cxx17_aligned_new_CXXFLAGS = -std=c++17 @FLAG_W_NO_MISMATCHED_NEW_DELETE@ +endif + +demangle_SOURCES = demangle.cpp +demangle_rust_SOURCES = demangle-rust.c +demangle_rust_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ dw4_CFLAGS = $(AM_CFLAGS) -gdwarf-4 -fdebug-types-section descr_belowsp_LDADD = -lpthread @@ -534,10 +552,6 @@ err_disable4_CFLAGS = $(AM_CFLAGS) if VGCONF_OS_IS_SOLARIS err_disable4_CFLAGS += -D_XOPEN_SOURCE=600 endif -reach_thread_register_CFLAGS = $(AM_CFLAGS) -O2 -reach_thread_register_LDADD = -lpthread -thread_alloca_LDADD = -lpthread -threadname_LDADD = -lpthread error_counts_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ @FLAG_W_NO_UNUSED_BUT_SET_VARIABLE@ @@ -545,7 +559,7 @@ execve1_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@ execve2_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@ -fprw_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ -Wno-free-nonheap-object +fprw_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ @FLAG_W_NO_FREE_NONHEAP_OBJECT@ @FLAG_W_NO_USE_AFTER_FREE@ inits_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ @@ -556,9 +570,12 @@ inltemplate_CXXFLAGS = $(AM_CXXFLAGS) @FLAG_W_NO_UNINITIALIZED@ long_namespace_xml_SOURCES = long_namespace_xml.cpp -manuel1_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ +malloc_free_fill_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ +malloc1_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ +manuel1_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ +manuel3_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ -memalign2_CFLAGS = $(AM_CFLAGS) -Wno-non-power-of-two-alignment +memalign2_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NON_POWER_OF_TWO_ALIGNMENT@ if VGCONF_OS_IS_SOLARIS memalign2_CFLAGS += -D__EXTENSIONS__ endif @@ -571,6 +588,8 @@ mismatches_CXXFLAGS = $(AM_CXXFLAGS) @FLAG_W_NO_MISMATCHED_NEW_DELETE@ new_nothrow_SOURCES = new_nothrow.cpp new_override_SOURCES = new_override.cpp +noisy_child_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ + if VGCONF_OS_IS_SOLARIS null_socket_LDADD = -lsocket -lnsl endif @@ -582,7 +601,7 @@ origin2_not_quite_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ origin3_no_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ # This requires optimisation in order to get just one resulting error. -origin4_many_CFLAGS = $(AM_CFLAGS) -O +origin4_many_CFLAGS = $(AM_CFLAGS) -O @FLAG_W_NO_USE_AFTER_FREE@ @FLAG_W_NO_UNINITIALIZED@ # Apply -O so as to run in reasonable time. origin5_bz2_CFLAGS = $(AM_CFLAGS) -O -Wno-inline @@ -591,7 +610,11 @@ origin6_fp_CFLAGS = $(AM_CFLAGS) -O # Don't allow GCC to inline memcpy() and strcpy(), # because then we can't intercept it overlap_CFLAGS = $(AM_CFLAGS) -fno-builtin-memcpy -fno-builtin-strcpy \ - -Wno-fortify-source + -Wno-fortify-source @FLAG_W_NO_STRINGOP_OVERFLOW@ + +partial_load_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ +reach_thread_register_CFLAGS = $(AM_CFLAGS) -O2 +reach_thread_register_LDADD = -lpthread resvn_stack_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ @@ -602,15 +625,14 @@ sendmsg_LDADD = -lsocket -lnsl endif if HAVE_FSIZED_DEALLOCATION -check_PROGRAMS += sized_delete sized_delete_SOURCES = sized_delete.cpp sized_delete_CXXFLAGS = $(AM_CXXFLAGS) @FLAG_FSIZED_DEALLOCATION@ endif -str_tester_CFLAGS = $(AM_CFLAGS) -Wno-shadow -Wno-stringop-overflow \ +str_tester_CFLAGS = $(AM_CFLAGS) -Wno-shadow @FLAG_W_NO_STRINGOP_OVERFLOW@ \ -Wno-stringop-truncation \ -Wno-fortify-source -Wno-suspicious-bzero \ - @FLAG_W_NO_MEMSET_TRANSPOSED_ARGS@ + @FLAG_W_NO_MEMSET_TRANSPOSED_ARGS@ @FLAG_W_NO_STRINGOP_OVERREAD@ supp_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ @@ -623,6 +645,13 @@ supp1_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ supp2_SOURCES = supp.c supp2_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ +suppfree_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ +test_plo_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ + +thread_alloca_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_FORMAT_OVERFLOW@ +thread_alloca_LDADD = -lpthread +threadname_LDADD = -lpthread + vcpu_bz2_CFLAGS = $(AM_CFLAGS) -O2 vcpu_fbench_CFLAGS = $(AM_CFLAGS) -O2 vcpu_fnfns_CFLAGS = $(AM_CFLAGS) -O2 @@ -631,12 +660,12 @@ wrap6_CFLAGS = $(AM_CFLAGS) -O2 # To make it a bit more realistic, have some optimisation enabled # for the varinfo tests. We still expect sane results. -varinfo1_CFLAGS = $(AM_CFLAGS) -O -varinfo2_CFLAGS = $(AM_CFLAGS) -O -Wno-shadow -varinfo3_CFLAGS = $(AM_CFLAGS) -O -varinfo4_CFLAGS = $(AM_CFLAGS) -O +varinfo1_CFLAGS = $(AM_CFLAGS) -O @FLAG_W_NO_MAYBE_UNINITIALIZED@ +varinfo2_CFLAGS = $(AM_CFLAGS) -O -Wno-shadow @FLAG_W_NO_MAYBE_UNINITIALIZED@ +varinfo3_CFLAGS = $(AM_CFLAGS) -O @FLAG_W_NO_MAYBE_UNINITIALIZED@ +varinfo4_CFLAGS = $(AM_CFLAGS) -O @FLAG_W_NO_MAYBE_UNINITIALIZED@ varinfo5_CFLAGS = $(AM_CFLAGS) -O -varinfo6_CFLAGS = $(AM_CFLAGS) -O +varinfo6_CFLAGS = $(AM_CFLAGS) -O @FLAG_W_NO_MAYBE_UNINITIALIZED@ # Build shared object for varinfo5 varinfo5_SOURCES = varinfo5.c @@ -651,7 +680,7 @@ else endif varinfo5so_so_SOURCES = varinfo5so.c -varinfo5so_so_CFLAGS = $(AM_CFLAGS) -fpic -O -Wno-shadow +varinfo5so_so_CFLAGS = $(AM_CFLAGS) -fpic -O -Wno-shadow @FLAG_W_NO_MAYBE_UNINITIALIZED@ if VGCONF_OS_IS_DARWIN varinfo5so_so_LDFLAGS = -fpic $(AM_FLAG_M3264_PRI) -dynamic \ -dynamiclib -all_load @@ -705,11 +734,6 @@ else -Wl,-soname -Wl,wrapmallocso.so endif -xml1_CFLAGS = $(AM_CFLAGS) -D_GNU_SOURCE +writev1_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_STRINGOP_OVERFLOW@ @FLAG_W_NO_STRINGOP_OVERREAD@ +xml1_CFLAGS = $(AM_CFLAGS) -D_GNU_SOURCE @FLAG_W_NO_UNINITIALIZED@ @FLAG_W_NO_USE_AFTER_FREE@ -if HAVE_ALIGNED_CXX_ALLOC -check_PROGRAMS += cxx17_aligned_new -cxx17_aligned_new_SOURCES = cxx17_aligned_new.cpp -# need C++ 17, and we deliberately mismatch new and delete -cxx17_aligned_new_CXXFLAGS = -std=c++17 -Wno-mismatched-new-delete -endif diff --git a/memcheck/tests/amd64/Makefile.am b/memcheck/tests/amd64/Makefile.am index a5a78aa310..d3b1386a32 100644 --- a/memcheck/tests/amd64/Makefile.am +++ b/memcheck/tests/amd64/Makefile.am @@ -76,4 +76,4 @@ insn_pcmpistri_CFLAGS = $(AM_CFLAGS) more_x87_fp_CFLAGS = $(AM_CFLAGS) -O -ffast-math -mfpmath=387 \ -mfancy-math-387 more_x87_fp_LDADD = -lm -shr_edx_CFLAGS = $(AM_CFLAGS) @FLAG_NO_PIE@ +shr_edx_CFLAGS = $(AM_CFLAGS) @FLAG_NO_PIE@ @FLAG_W_NO_UNINITIALIZED@ diff --git a/memcheck/tests/linux/Makefile.am b/memcheck/tests/linux/Makefile.am index d5991dc5e5..64160c0c8e 100644 --- a/memcheck/tests/linux/Makefile.am +++ b/memcheck/tests/linux/Makefile.am @@ -101,3 +101,9 @@ dlclose_leak_DEPENDENCIES = dlclose_leak_so.so dlclose_leak_LDADD = -ldl dlclose_leak_LDFLAGS = $(AM_FLAG_M3264_PRI) \ -Wl,-rpath,$(top_builddir)/memcheck/tests/linux + +enomem_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_USE_AFTER_FREE@ +sys_preadv_pwritev_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_STRINGOP_OVERFLOW@ @FLAG_W_NO_STRINGOP_OVERREAD@ \ + @FLAG_W_NO_NONNULL@ +sys_preadv2_pwritev2_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@ @FLAG_W_NO_STRINGOP_OVERREAD@ \ + @FLAG_W_NO_STRINGOP_OVERFLOW@ diff --git a/memcheck/tests/x86-linux/Makefile.am b/memcheck/tests/x86-linux/Makefile.am index 04c18442ef..6f9b2d4da6 100644 --- a/memcheck/tests/x86-linux/Makefile.am +++ b/memcheck/tests/x86-linux/Makefile.am @@ -28,4 +28,6 @@ AM_CFLAGS += @FLAG_M32@ $(FLAG_MMMX) $(FLAG_MSSE) AM_CXXFLAGS += @FLAG_M32@ $(FLAG_MMMX) $(FLAG_MSSE) AM_CCASFLAGS += @FLAG_M32@ -scalar_supp_CFLAGS = $(AM_CFLAGS) -Wno-uninitialized +scalar_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ +scalar_exit_group_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ +scalar_supp_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@ diff --git a/none/tests/Makefile.am b/none/tests/Makefile.am index 871ec62777..ee2181f2dc 100644 --- a/none/tests/Makefile.am +++ b/none/tests/Makefile.am @@ -369,6 +369,7 @@ thread_exits_LDADD = -lpthread threaded_fork_LDADD = -lpthread threadederrno_CFLAGS = $(AM_CFLAGS) threadederrno_LDADD = -lpthread +timestamp_CFLAGS = -lpthread @FLAG_W_NO_USE_AFTER_FREE@ tls_SOURCES = tls.c tls2.c tls_DEPENDENCIES = tls.so tls2.so tls_LDFLAGS = -Wl,-rpath,$(abs_top_builddir)/none/tests