From: Ondřej Kuzník <ondra@mistotebe.net>
Date: Fri, 26 Feb 2021 09:00:39 +0000 (+0000)
Subject: ITS#9288 Do no change tainted status on failed retry
X-Git-Tag: OPENLDAP_REL_ENG_2_5_3BETA~6^2~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99efeda06f9c923f0e267a1b6555b4b0f1173f52;p=thirdparty%2Fopenldap.git

ITS#9288 Do no change tainted status on failed retry

It seems refcnt == 0 connections are tainted only if they were just
removed from cache.
---

diff --git a/servers/slapd/back-ldap/bind.c b/servers/slapd/back-ldap/bind.c
index 68ab46224f..395112504a 100644
--- a/servers/slapd/back-ldap/bind.c
+++ b/servers/slapd/back-ldap/bind.c
@@ -2022,7 +2022,6 @@ ldap_back_retry( ldapconn_t **lcp, Operation *op, SlapReply *rs, ldap_back_send_
 			if ( rc == 0 && *lcp != NULL ) {
 				/* freeit, because lc_refcnt == 1 */
 				(*lcp)->lc_refcnt = 0;
-				LDAP_BACK_CONN_TAINTED_SET( *lcp );
 				(void)ldap_back_freeconn( li, *lcp, 0 );
 				*lcp = NULL;
 			}