From: Victor Julien <vjulien@oisf.net>
Date: Sun, 9 Mar 2025 13:54:16 +0000 (+0100)
Subject: detect/dcerpc.iface: remove commented out unittest
X-Git-Tag: suricata-8.0.0-beta1~294
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99f151c9077080d26e6ed151f1f331cb986bcf77;p=thirdparty%2Fsuricata.git

detect/dcerpc.iface: remove commented out unittest
---

diff --git a/src/detect-dce-iface.c b/src/detect-dce-iface.c
index 987d0a48c9..63c362d01e 100644
--- a/src/detect-dce-iface.c
+++ b/src/detect-dce-iface.c
@@ -58,9 +58,6 @@ static int DetectDceIfaceMatchRust(DetectEngineThreadCtx *det_ctx,
         const Signature *s, const SigMatchCtx *m);
 static int DetectDceIfaceSetup(DetectEngineCtx *, Signature *, const char *);
 static void DetectDceIfaceFree(DetectEngineCtx *, void *);
-#ifdef UNITTESTS
-static void DetectDceIfaceRegisterTests(void);
-#endif
 static int g_dce_generic_list_id = 0;
 
 /**
@@ -72,10 +69,7 @@ void DetectDceIfaceRegister(void)
     sigmatch_table[DETECT_DCE_IFACE].alias = "dce_iface";
     sigmatch_table[DETECT_DCE_IFACE].AppLayerTxMatch = DetectDceIfaceMatchRust;
     sigmatch_table[DETECT_DCE_IFACE].Setup = DetectDceIfaceSetup;
-    sigmatch_table[DETECT_DCE_IFACE].Free  = DetectDceIfaceFree;
-#ifdef UNITTESTS
-    sigmatch_table[DETECT_DCE_IFACE].RegisterTests = DetectDceIfaceRegisterTests;
-#endif
+    sigmatch_table[DETECT_DCE_IFACE].Free = DetectDceIfaceFree;
     DetectSetupParseRegexes(PARSE_REGEX, &parse_regex);
 
     g_dce_generic_list_id = DetectBufferTypeRegister("dce_generic");
@@ -169,357 +163,3 @@ static void DetectDceIfaceFree(DetectEngineCtx *de_ctx, void *ptr)
     }
     SCReturn;
 }
-
-/************************************Unittests*********************************/
-
-#ifdef UNITTESTS
-
-/* Disabled because of bug_753.  Would be enabled, once we rewrite
- * dce parser */
-#if 0
-
-/**
- * \test Test a valid dce_iface entry with a bind, bind_ack and 3 request/responses.
- */
-static int DetectDceIfaceTestParse13(void)
-{
-    int result = 0;
-    Signature *s = NULL;
-    ThreadVars th_v;
-    Packet *p = NULL;
-    Flow f;
-    TcpSession ssn;
-    DetectEngineThreadCtx *det_ctx = NULL;
-    DetectEngineCtx *de_ctx = NULL;
-    DCERPCState *dcerpc_state = NULL;
-    int r = 0;
-
-    uint8_t dcerpc_bind[] = {
-        0x05, 0x00, 0x0b, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0x48, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
-        0xb8, 0x10, 0xb8, 0x10, 0x00, 0x00, 0x00, 0x00,
-        0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00,
-        0x01, 0xd0, 0x8c, 0x33, 0x44, 0x22, 0xf1, 0x31,
-        0xaa, 0xaa, 0x90, 0x00, 0x38, 0x00, 0x10, 0x03,
-        0x01, 0x00, 0x00, 0x00, 0x04, 0x5d, 0x88, 0x8a,
-        0xeb, 0x1c, 0xc9, 0x11, 0x9f, 0xe8, 0x08, 0x00,
-        0x2b, 0x10, 0x48, 0x60, 0x02, 0x00, 0x00, 0x00,
-    };
-
-    uint8_t dcerpc_bindack[] = {
-        0x05, 0x00, 0x0c, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0x44, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
-        0xb8, 0x10, 0xb8, 0x10, 0x65, 0x8e, 0x00, 0x00,
-        0x0d, 0x00, 0x5c, 0x50, 0x49, 0x50, 0x45, 0x5c,
-        0x77, 0x69, 0x6e, 0x72, 0x65, 0x67, 0x00, 0x6d,
-        0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-        0x04, 0x5d, 0x88, 0x8a, 0xeb, 0x1c, 0xc9, 0x11,
-        0x9f, 0xe8, 0x08, 0x00, 0x2b, 0x10, 0x48, 0x60,
-        0x02, 0x00, 0x00, 0x00,
-    };
-
-    uint8_t dcerpc_request1[] = {
-        0x05, 0x00, 0x00, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0x24, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
-        0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00,
-        0x2c, 0xfd, 0xb5, 0x00, 0x40, 0xaa, 0x01, 0x00,
-        0x00, 0x00, 0x00, 0x02,
-    };
-
-    uint8_t dcerpc_response1[] = {
-        0x05, 0x00, 0x02, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0x30, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
-        0x18, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-        0x00, 0x00, 0x00, 0x00, 0xf6, 0x72, 0x28, 0x9c,
-        0xf0, 0x57, 0xd8, 0x11, 0xb0, 0x05, 0x00, 0x0c,
-        0x29, 0x87, 0xea, 0xe9, 0x00, 0x00, 0x00, 0x00,
-    };
-
-    uint8_t dcerpc_request2[] = {
-        0x05, 0x00, 0x00, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0xa4, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00,
-        0x8c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x0f, 0x00,
-        0x00, 0x00, 0x00, 0x00, 0xf6, 0x72, 0x28, 0x9c,
-        0xf0, 0x57, 0xd8, 0x11, 0xb0, 0x05, 0x00, 0x0c,
-        0x29, 0x87, 0xea, 0xe9, 0x5c, 0x00, 0x5c, 0x00,
-        0xa8, 0xb9, 0x14, 0x00, 0x2e, 0x00, 0x00, 0x00,
-        0x00, 0x00, 0x00, 0x00, 0x2e, 0x00, 0x00, 0x00,
-        0x53, 0x00, 0x4f, 0x00, 0x46, 0x00, 0x54, 0x00,
-        0x57, 0x00, 0x41, 0x00, 0x52, 0x00, 0x45, 0x00,
-        0x5c, 0x00, 0x4d, 0x00, 0x69, 0x00, 0x63, 0x00,
-        0x72, 0x00, 0x6f, 0x00, 0x73, 0x00, 0x6f, 0x00,
-        0x66, 0x00, 0x74, 0x00, 0x5c, 0x00, 0x57, 0x00,
-        0x69, 0x00, 0x6e, 0x00, 0x64, 0x00, 0x6f, 0x00,
-        0x77, 0x00, 0x73, 0x00, 0x5c, 0x00, 0x43, 0x00,
-        0x75, 0x00, 0x72, 0x00, 0x72, 0x00, 0x65, 0x00,
-        0x6e, 0x00, 0x74, 0x00, 0x56, 0x00, 0x65, 0x00,
-        0x72, 0x00, 0x73, 0x00, 0x69, 0x00, 0x6f, 0x00,
-        0x6e, 0x00, 0x5c, 0x00, 0x52, 0x00, 0x75, 0x00,
-        0x6e, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-        0x03, 0x00, 0x00, 0x00,
-    };
-
-    uint8_t dcerpc_response2[] = {
-        0x05, 0x00, 0x02, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0x30, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00,
-        0x18, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-        0x00, 0x00, 0x00, 0x00, 0xf7, 0x72, 0x28, 0x9c,
-        0xf0, 0x57, 0xd8, 0x11, 0xb0, 0x05, 0x00, 0x0c,
-        0x29, 0x87, 0xea, 0xe9, 0x00, 0x00, 0x00, 0x00,
-    };
-
-    uint8_t dcerpc_request3[] = {
-        0x05, 0x00, 0x00, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0x70, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00,
-        0x58, 0x00, 0x00, 0x00, 0x00, 0x00, 0x16, 0x00,
-        0x00, 0x00, 0x00, 0x00, 0xf7, 0x72, 0x28, 0x9c,
-        0xf0, 0x57, 0xd8, 0x11, 0xb0, 0x05, 0x00, 0x0c,
-        0x29, 0x87, 0xea, 0xe9, 0x0c, 0x00, 0x0c, 0x00,
-        0x98, 0xda, 0x14, 0x00, 0x06, 0x00, 0x00, 0x00,
-        0x00, 0x00, 0x00, 0x00, 0x06, 0x00, 0x00, 0x00,
-        0x4f, 0x00, 0x73, 0x00, 0x61, 0x00, 0x33, 0x00,
-        0x32, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
-        0x18, 0x00, 0x00, 0x00, 0x4e, 0x00, 0x54, 0x00,
-        0x4f, 0x00, 0x53, 0x00, 0x41, 0x00, 0x33, 0x00,
-        0x32, 0x00, 0x2e, 0x00, 0x45, 0x00, 0x58, 0x00,
-        0x45, 0x00, 0x00, 0x00, 0x18, 0x00, 0x00, 0x00,
-    };
-
-    uint8_t dcerpc_response3[] = {
-        0x05, 0x00, 0x02, 0x03, 0x10, 0x00, 0x00, 0x00,
-        0x1c, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00,
-        0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-        0x00, 0x00, 0x00, 0x00,
-    };
-
-    uint32_t dcerpc_bind_len = sizeof(dcerpc_bind);
-    uint32_t dcerpc_bindack_len = sizeof(dcerpc_bindack);
-
-    uint32_t dcerpc_request1_len = sizeof(dcerpc_request1);
-    uint32_t dcerpc_response1_len = sizeof(dcerpc_response1);
-
-    uint32_t dcerpc_request2_len = sizeof(dcerpc_request2);
-    uint32_t dcerpc_response2_len = sizeof(dcerpc_response2);
-
-    uint32_t dcerpc_request3_len = sizeof(dcerpc_request3);
-    uint32_t dcerpc_response3_len = sizeof(dcerpc_response3);
-
-    AppLayerParserThreadCtx *alp_tctx = AppLayerParserThreadCtxAlloc();
-
-    memset(&th_v, 0, sizeof(th_v));
-    memset(&p, 0, sizeof(p));
-    memset(&f, 0, sizeof(f));
-    memset(&ssn, 0, sizeof(ssn));
-
-    p = UTHBuildPacket(NULL, 0, IPPROTO_TCP);
-
-    FLOW_INITIALIZE(&f);
-    f.protoctx = (void *)&ssn;
-    f.proto = IPPROTO_TCP;
-    p->flow = &f;
-    p->flowflags |= FLOW_PKT_TOSERVER;
-    p->flowflags |= FLOW_PKT_ESTABLISHED;
-    p->flags |= PKT_HAS_FLOW|PKT_STREAM_EST;
-    f.alproto = ALPROTO_DCERPC;
-
-    StreamTcpInitConfig(true);
-
-    de_ctx = DetectEngineCtxInit();
-    if (de_ctx == NULL)
-        goto end;
-
-    de_ctx->flags |= DE_QUIET;
-
-    s = DetectEngineAppendSig(de_ctx,"alert tcp any any -> any any "
-            "(msg:\"DCERPC\"; dce_iface:338cd001-2244-31f1-aaaa-900038001003,=1,any_frag; sid:1;)");
-    if (s == NULL)
-        goto end;
-
-    SigGroupBuild(de_ctx);
-    DetectEngineThreadCtxInit(&th_v, (void *)de_ctx, (void *)&det_ctx);
-
-    SCLogDebug("chunk 1, bind");
-
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOSERVER | STREAM_START,
-                            dcerpc_bind, dcerpc_bind_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    dcerpc_state = f.alstate;
-    if (dcerpc_state == NULL) {
-        SCLogDebug("no dcerpc state: ");
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOCLIENT;
-    p->flowflags |= FLOW_PKT_TOSERVER;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (PacketAlertCheck(p, 1)) {
-        SCLogDebug("sig 1 didn't match after bind request: ");
-        goto end;
-    }
-
-    SCLogDebug("chunk 2, bind_ack");
-
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOCLIENT, dcerpc_bindack,
-                            dcerpc_bindack_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOSERVER;
-    p->flowflags |= FLOW_PKT_TOCLIENT;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (PacketAlertCheck(p, 1)) {
-        SCLogDebug("sig 1 matched again after bind ack: ");
-        goto end;
-    }
-
-    SCLogDebug("chunk 3, request 1");
-
-    /* request1 */
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOSERVER, dcerpc_request1,
-                            dcerpc_request1_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOCLIENT;
-    p->flowflags |= FLOW_PKT_TOSERVER;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (!(PacketAlertCheck(p, 1))) {
-        SCLogDebug("sig 1 didn't match after request1: ");
-        goto end;
-    }
-
-    SCLogDebug("sending response1");
-
-    /* response1 */
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOCLIENT, dcerpc_response1,
-                            dcerpc_response1_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOSERVER;
-    p->flowflags |= FLOW_PKT_TOCLIENT;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (PacketAlertCheck(p, 1)) {
-        SCLogDebug("sig 1 matched after response1, but shouldn't: ");
-        goto end;
-    }
-
-    SCLogDebug("sending request2");
-
-    /* request2 */
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOSERVER, dcerpc_request2,
-                            dcerpc_request2_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOCLIENT;
-    p->flowflags |= FLOW_PKT_TOSERVER;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (!(PacketAlertCheck(p, 1))) {
-        SCLogDebug("sig 1 didn't match after request2: ");
-        goto end;
-    }
-
-    /* response2 */
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOCLIENT, dcerpc_response2,
-                            dcerpc_response2_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOSERVER;
-    p->flowflags |= FLOW_PKT_TOCLIENT;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (PacketAlertCheck(p, 1)) {
-        SCLogDebug("sig 1 matched after response2, but shouldn't have: ");
-        goto end;
-    }
-
-    /* request3 */
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOSERVER, dcerpc_request3,
-                            dcerpc_request3_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOCLIENT;
-    p->flowflags |= FLOW_PKT_TOSERVER;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (!(PacketAlertCheck(p, 1))) {
-        SCLogDebug("sig 1 didn't match after request3: ");
-        goto end;
-    }
-
-    /* response3 */
-    r = AppLayerParserParse(alp_tctx, &f, ALPROTO_DCERPC, STREAM_TOCLIENT | STREAM_EOF,
-                            dcerpc_response3, dcerpc_response3_len);
-    if (r != 0) {
-        SCLogDebug("AppLayerParse for dcerpc failed.  Returned %" PRId32, r);
-        goto end;
-    }
-
-    p->flowflags &=~ FLOW_PKT_TOSERVER;
-    p->flowflags |= FLOW_PKT_TOCLIENT;
-    /* do detect */
-    SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
-
-    if (PacketAlertCheck(p, 1)) {
-        SCLogDebug("sig 1 matched after response3, but shouldn't have: ");
-        goto end;
-    }
-
-    result = 1;
-
- end:
-    if (alp_tctx != NULL)
-        AppLayerParserThreadCtxFree(alp_tctx);
-    SigGroupCleanup(de_ctx);
-    SigCleanSignatures(de_ctx);
-
-    DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx);
-    DetectEngineCtxFree(de_ctx);
-
-    StreamTcpFreeConfig(true);
-    UTHFreePackets(&p, 1);
-    return result;
-}
-
-#endif
-
-static void DetectDceIfaceRegisterTests(void)
-{
-    /* Disabled because of bug_753.  Would be enabled, once we rewrite
-     * dce parser */
-#if 0
-    UtRegisterTest("DetectDceIfaceTestParse13", DetectDceIfaceTestParse13, 1);
-#endif
-}
-#endif /* UNITTESTS */