From: zach%zachlipton.com <>
Date: Tue, 5 Feb 2002 00:38:33 +0000 (+0000)
Subject: Fix for bug 87398: checksetup.pl should warn if not run as root. Patch
X-Git-Tag: bugzilla-2.16rc1~247
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99f91c7995f510e1ec2ae36224b935379bdc5f84;p=thirdparty%2Fbugzilla.git

Fix for bug 87398: checksetup.pl should warn if not run as root. Patch
adds a warning if the user has webservergroup set but does not run
checksetup.pl as root.

r1=kiko, r2=justdave
---

diff --git a/checksetup.pl b/checksetup.pl
index 71e501ffbb..93166218da 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -771,6 +771,20 @@ sub fixPerms {
 }
 
 if ($my_webservergroup) {
+        unless ($< == 0) { # zach: if not root, yell at them, bug 87398 
+        print <<EOF;
+
+Warning: you have entered a value for the "webservergroup" parameter
+in localconfig, but you are not running this script as root.
+This can cause permissions problems and decreased security.  If you
+experience problems running Bugzilla scripts, log in as root and re-run
+this script, or remove the value of the "webservergroup" parameter.
+Note that any warnings about "uninitialized values" that you may
+see below are caused by this.
+
+EOF
+    }
+
     # Funny! getgrname returns the GID if fed with NAME ...
     my $webservergid = getgrnam($my_webservergroup);
     # chown needs to be called with a valid uid, not 0.  $< returns the