From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 21 Feb 2013 14:34:31 +0000 (-0500)
Subject: Fix error strings to make more sense
X-Git-Tag: release_3_0_0_beta1~960
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=99fedbc5d138d49213de35bb279d218133aa29ed;p=thirdparty%2Ffreeradius-server.git

Fix error strings to make more sense
---

diff --git a/src/lib/dhcp.c b/src/lib/dhcp.c
index 486e865ef19..f42c035e0fb 100644
--- a/src/lib/dhcp.c
+++ b/src/lib/dhcp.c
@@ -694,7 +694,9 @@ int fr_dhcp_decode(RADIUS_PACKET *packet)
 	for (i = 0; i < 14; i++) {
 		vp = pairmake(dhcp_header_names[i], NULL, T_OP_EQ);
 		if (!vp) {
-			fr_strerror_printf("Parse error %s", fr_strerror());
+			char buffer[256];
+			strlcpy(buffer, fr_strerror(), sizeof(buffer));
+			fr_strerror_printf("Cannot decode packet due to internal error: %s", buffer);
 			pairfree(&head);
 			return -1;
 		}
@@ -1327,7 +1329,9 @@ int fr_dhcp_encode(RADIUS_PACKET *packet, RADIUS_PACKET *original)
 		for (i = 0; i < 14; i++) {
 			vp = pairmake(dhcp_header_names[i], NULL, T_OP_EQ);
 			if (!vp) {
-				fr_strerror_printf("Parse error %s", fr_strerror());
+				char buffer[256];
+				strlcpy(buffer, fr_strerror(), sizeof(buffer));
+				fr_strerror_printf("Cannot decode packet due to internal error: %s", buffer);
 				return -1;
 			}