From: RafiBomb Date: Fri, 6 May 2016 15:48:17 +0000 (-0700) Subject: adds more use cases to inliner test X-Git-Tag: v2.2.0~23 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9a09698fcd2e7c587710baaad3937d76c9354dd2;p=thirdparty%2Ffoundation%2Ffoundation-emails.git adds more use cases to inliner test --- diff --git a/gulpfile.js b/gulpfile.js index e4687227..69044c52 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -209,7 +209,8 @@ function inliner(css) { var pipe = lazypipe() .pipe($.inlineCss, { applyStyleTags: false, - removeStyleTags: false + removeStyleTags: false, + removeLinkTags: false }) .pipe($.injectString.replace, '', '') .pipe($.htmlmin, { diff --git a/package.json b/package.json index f5e695b6..723b1c22 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "gulp-sourcemaps": "^1.6.0", "gulp-wrap": "^0.11.0", "gulp-zip": "^3.2.0", - "inky": "zurb/inky", + "inky": "zurb/inky#fix-character-escaping", "lazypipe": "^1.0.1", "motion-ui": "^1.1.1", "multiline": "^1.0.2", diff --git a/test/visual/pages/inliner-bugs.html b/test/visual/pages/inliner-bugs.html index 6477c3dd..5a2a379a 100644 --- a/test/visual/pages/inliner-bugs.html +++ b/test/visual/pages/inliner-bugs.html @@ -5,7 +5,7 @@ #417 - 2 sets of angle backets: outer set should not get converted to charachter codes. you should not see 2 angle brackets here:
<> - confirmed on inliner + confirmed on inliner (both) need to
@@ -13,8 +13,30 @@ #337 - Should not be converted to ampersand apos;
' +
+ Inky issue + +
+ mdash; should not be converted to #x2014; +
+ — +
+ Inky issue +
+ + + quotes should not be converted to quot; +
+ " +
Inky issue +
+ ellipsis should not be converted to #x2019; +
+ … +
+ Inky issue
#384 - Should not be converted to ampersand and nbsp