From: drh <> Date: Mon, 12 Jan 2026 19:56:00 +0000 (+0000) Subject: Avoid unsigned integer overflow in the delta_apply() extension function. X-Git-Tag: artiphishell~7 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9a341c1edbde5c3b9637a5775721ebd7fcae8959;p=thirdparty%2Fsqlite.git Avoid unsigned integer overflow in the delta_apply() extension function. Not part of any standard deliverable. [forum:/forumpost/d41879b367c7f7ec|Forum thread d41879b367c7f7ec]. FossilOrigin-Name: b354dd12c25c820c04b08e0be4ba8c095fc648dfb4b71345aacce50a17fd269a --- diff --git a/ext/misc/fossildelta.c b/ext/misc/fossildelta.c index b9ff27c532..2dc29b3c3b 100644 --- a/ext/misc/fossildelta.c +++ b/ext/misc/fossildelta.c @@ -543,8 +543,8 @@ static int delta_apply( int lenDelta, /* Length of the delta */ char *zOut /* Write the output into this preallocated buffer */ ){ - unsigned int limit; - unsigned int total = 0; + sqlite3_uint64 limit; + sqlite3_uint64 total = 0; #ifdef FOSSIL_ENABLE_DELTA_CKSUM_TEST char *zOrigOut = zOut; #endif diff --git a/manifest b/manifest index 23f91be31f..9d521bc0d4 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Fix\san\sinfinite\sloop\sin\sthe\ssessions\smodule\sthat\scould\soccur\swhen\sprocessing\sa\scorrupt\schangeset\sblob. -D 2026-01-12T19:13:09.778 +C Avoid\sunsigned\sinteger\soverflow\sin\sthe\sdelta_apply()\sextension\sfunction.\nNot\spart\sof\sany\sstandard\sdeliverable.\s\s\n[forum:/forumpost/d41879b367c7f7ec|Forum\sthread\sd41879b367c7f7ec]. +D 2026-01-12T19:56:00.298 F .fossil-settings/binary-glob 61195414528fb3ea9693577e1980230d78a1f8b0a54c78cf1b9b24d0a409ed6a x F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea @@ -373,7 +373,7 @@ F ext/misc/decimal.c d4883de142f6dcd36eda23da40b55e2b51374e7b01eb54a717394019138 F ext/misc/eval.c 04bc9aada78c888394204b4ed996ab834b99726fb59603b0ee3ed6e049755dc1 F ext/misc/explain.c 606100185fb90d6a1eade1ed0414d53503c86820d8956a06e3b0a56291894f2b F ext/misc/fileio.c 452300ca34fadafd2bb9eb09557de5a518da1fd2349f9f9cedd22b1566a7164f -F ext/misc/fossildelta.c 547d0b6744dbec531f081a8c52daf302c38d72da5f548307ee8f72a6618ff419 +F ext/misc/fossildelta.c 86dfa83f85f7ccd640591d8a5c6865346d0c2ee6a949d78591eceb892f1cbfec F ext/misc/fuzzer.c 6b231352815304ba60d8e9ec2ee73d4918e74d9b76bda8940ba2b64e8777515e F ext/misc/ieee754.c 7d7ecdd9490f6746ad88e0aa4f073ea66422341dce062d24d1b4d47d2e9050d6 F ext/misc/memstat.c 43705d795090efb78c85c736b89251e743c291e23daaa8382fe7a0df2c6a283d @@ -2191,8 +2191,8 @@ F tool/warnings-clang.sh bbf6a1e685e534c92ec2bfba5b1745f34fb6f0bc2a362850723a9ee F tool/warnings.sh d924598cf2f55a4ecbc2aeb055c10bd5f48114793e7ba25f9585435da29e7e98 F tool/win/sqlite.vsix deb315d026cc8400325c5863eef847784a219a2f F tool/winmain.c 00c8fb88e365c9017db14c73d3c78af62194d9644feaf60e220ab0f411f3604c -P b57a8215f4259a0aae188b7ee5060f8ff48919303179aae80b58b43ed3b991f5 -R 3399b1c19b205e4064131fb24d30ccfb -U dan -Z 752e80f90e8cbd05a6ddad6434f2092c +P d98653bdbc9781970f1c5d66f69c81c93ad14549223ceae02e74c1b99ab05377 +R 3f9dab5c6c5ab8ad7249618d441d5de4 +U drh +Z 401dca944da578f646785c1e8ff1019c # Remove this line to create a well-formed Fossil manifest. diff --git a/manifest.uuid b/manifest.uuid index 88e8889de9..d9962bb7af 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -d98653bdbc9781970f1c5d66f69c81c93ad14549223ceae02e74c1b99ab05377 +b354dd12c25c820c04b08e0be4ba8c095fc648dfb4b71345aacce50a17fd269a