From: Michal Privoznik <mprivozn@redhat.com>
Date: Tue, 15 Jun 2021 16:01:37 +0000 (+0200)
Subject: virFindFileInPath: Don't pass NULL to g_canonicalize_filename()
X-Git-Tag: v7.5.0-rc1~71
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9a51edebf88556823e05c3710ec378c976ce3386;p=thirdparty%2Flibvirt.git

virFindFileInPath: Don't pass NULL to g_canonicalize_filename()

If given file is not found in $PATH then g_find_program_in_path()
returns NULL. However, g_canonicalize_filename() does not accept
NULL as input.

Fixes: 65c2901906b5e2d707f9184ff3719a5375bab427
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/util/virfile.c b/src/util/virfile.c
index c302202573..4f98b011be 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -1667,6 +1667,8 @@ virFindFileInPath(const char *file)
         return NULL;
 
     path = g_find_program_in_path(file);
+    if (!path)
+        return NULL;
 
     /* Workaround for a bug in g_find_program_in_path() not returning absolute
      * path as documented.  This has been fixed in