From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 10 Jul 2024 15:01:47 +0000 (+0200)
Subject: terminal-util: refuse a few more unexpected open flags in open_terminal()
X-Git-Tag: v257-rc1~873^2~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9a5e421af5b2cf3f997bd94a8dc8563ba2a3b37c;p=thirdparty%2Fsystemd.git

terminal-util: refuse a few more unexpected open flags in open_terminal()
---

diff --git a/src/basic/terminal-util.c b/src/basic/terminal-util.c
index e3e0295c8e2..345fc15b94a 100644
--- a/src/basic/terminal-util.c
+++ b/src/basic/terminal-util.c
@@ -344,7 +344,7 @@ int open_terminal(const char *name, int mode) {
          * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/554172/comments/245
          */
 
-        if (mode & O_CREAT)
+        if ((mode & (O_CREAT|O_PATH|O_DIRECTORY|O_TMPFILE)) != 0)
                 return -EINVAL;
 
         for (;;) {