From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 7 Feb 2025 16:04:07 +0000 (+0000)
Subject: job: Don't crash when no packages have been uploaded
X-Git-Tag: 0.9.30~94
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9a68d5e6c9d61c8eaa271a131b5a5733b0de3599;p=pakfire.git

job: Don't crash when no packages have been uploaded

I remove a check earlier which this code relied on.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/pakfire/job.c b/src/pakfire/job.c
index 5ec9531f..404f2415 100644
--- a/src/pakfire/job.c
+++ b/src/pakfire/job.c
@@ -345,10 +345,12 @@ static int pakfire_job_finished(struct pakfire_job* job, int status) {
 	}
 
 	// Packages
-	for (char** upload = job->uploads; *upload; upload++) {
-		r = pakfire_xfer_add_param(xfer, "package", "%s", *upload);
-		if (r < 0)
-			goto ERROR;
+	if (job->uploads) {
+		for (char** upload = job->uploads; *upload; upload++) {
+			r = pakfire_xfer_add_param(xfer, "package", "%s", *upload);
+			if (r < 0)
+				goto ERROR;
+		}
 	}
 
 	// Send the request