From: Michihiro NAKAJIMA <ggcueroad@gmail.com>
Date: Mon, 9 Nov 2009 07:27:38 +0000 (-0500)
Subject: Although the value stored to 'v' is used in the enclosing expression,
X-Git-Tag: v2.8.0~192
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9a85e8210b96b092e6d72db5ba6e30cc1deaea9e;p=thirdparty%2Flibarchive.git

Although the value stored to 'v' is used in the enclosing expression,
the value is never actually read from 'v'

Found by Clang Static Analyzer.

SVN-Revision: 1623
---

diff --git a/libarchive/archive_write_set_format_cpio.c b/libarchive/archive_write_set_format_cpio.c
index 4457496d1..4becb21cf 100644
--- a/libarchive/archive_write_set_format_cpio.c
+++ b/libarchive/archive_write_set_format_cpio.c
@@ -222,7 +222,7 @@ format_octal_recursive(int64_t v, char *p, int s)
 		return (v);
 	v = format_octal_recursive(v, p+1, s-1);
 	*p = '0' + (v & 7);
-	return (v >>= 3);
+	return (v >> 3);
 }
 
 static int