From: Tom Hromatka Date: Tue, 27 Apr 2021 17:06:26 +0000 (+0000) Subject: lscgroup: Fix strncpy() truncation warning X-Git-Tag: v2.0~2^2~3 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ab3bbd8416909ee27374980f64656340409a438;p=thirdparty%2Flibcgroup.git lscgroup: Fix strncpy() truncation warning Fix the following strncpy() string truncation warning: In function ‘strncpy’, inlined from ‘display_controller_data’ at lscgroup.c:99:2: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 4096 equals destination size [-Wstringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Tom Hromatka --- diff --git a/src/tools/lscgroup.c b/src/tools/lscgroup.c index bfb1724f..305b3428 100644 --- a/src/tools/lscgroup.c +++ b/src/tools/lscgroup.c @@ -97,6 +97,7 @@ static int display_controller_data(char *input_path, char *controller, char *nam return ret; strncpy(cgroup_dir_path, info.full_path, FILENAME_MAX); + cgroup_dir_path[sizeof(cgroup_dir_path) - 1] = '\0'; /* remove problematic '/' characters from cgroup directory path*/ trim_filepath(cgroup_dir_path);