From: James Jones <jejones3141@gmail.com>
Date: Thu, 16 Jun 2022 18:39:32 +0000 (-0500)
Subject: More annotation of Coverity false positives. (#4568)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ad21ccb6326ae224128c0872188746f155eaa39;p=thirdparty%2Ffreeradius-server.git

More annotation of Coverity false positives. (#4568)

This deals with the following CIDs: 1504662, 1469149
---

diff --git a/src/lib/server/connection.c b/src/lib/server/connection.c
index 5dad7381c3e..d5754e212f7 100644
--- a/src/lib/server/connection.c
+++ b/src/lib/server/connection.c
@@ -296,6 +296,7 @@ static void connection_deferred_signal_process(fr_connection_t *conn)
 		 *	One of the signal handlers freed the connection
 		 *	return immediately.
 		 */
+		/* coverity[deadcode] */
 		if (freed) return;
 	}
 
diff --git a/src/lib/unlang/xlat_purify.c b/src/lib/unlang/xlat_purify.c
index 31cace61652..7fd44156e95 100644
--- a/src/lib/unlang/xlat_purify.c
+++ b/src/lib/unlang/xlat_purify.c
@@ -79,7 +79,7 @@ int xlat_purify_list(xlat_exp_head_t *head, request_t *request)
 		default:
 			fr_strerror_printf("Internal error - cannot purify xlat");
 			return -1;
-			
+
 		case XLAT_GROUP:
 			rcode = xlat_purify_list(node->group, request);
 			if (rcode < 0) return rcode;
@@ -102,14 +102,14 @@ int xlat_purify_list(xlat_exp_head_t *head, request_t *request)
 			 *	with the children.  But only if the
 			 *	child list is not empty.
 			 */
-			
+
 			if (node->alternate[1]->flags.can_purify) {
 				rcode = xlat_purify_list(node->alternate[1], request);
 				if (rcode < 0) return rcode;
 			}
 			xlat_flags_merge(&node->flags, &node->alternate[1]->flags);
 			break;
-			
+
 		case XLAT_FUNC:
 			/*
 			 *	If the node is not pure, then maybe there's a callback to purify it, OR maybe
@@ -152,6 +152,7 @@ int xlat_purify_list(xlat_exp_head_t *head, request_t *request)
 			 */
 			success = false;
 			(void) unlang_interpret_synchronous(NULL, request);
+			/* coverity[deadcode] */
 			if (!success) return -1;
 
 			/*