From: lpsolit%gmail.com <>
Date: Sat, 21 Feb 2009 00:26:03 +0000 (+0000)
Subject: Bug 479345: Field::Choice->update returns incorrect data in list context, leading... 
X-Git-Tag: bugzilla-3.3.4~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ae356d7ce269f120c815705f41e93e266d5a75a;p=thirdparty%2Fbugzilla.git

Bug 479345: Field::Choice->update returns incorrect data in list context, leading group settings changes to crash - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
---

diff --git a/Bugzilla/Field/Choice.pm b/Bugzilla/Field/Choice.pm
index 00fa52f993..5f1578d2b0 100644
--- a/Bugzilla/Field/Choice.pm
+++ b/Bugzilla/Field/Choice.pm
@@ -171,7 +171,7 @@ sub update {
     }
 
     $dbh->bz_commit_transaction();
-    return $changes;
+    return wantarray ? ($changes, $old_self) : $changes;
 }
 
 sub remove_from_db {