From: Nick Mathewson Date: Fri, 20 Jul 2018 15:02:05 +0000 (-0400) Subject: Tweak assertion in get_time_period_length() for coverity X-Git-Tag: tor-0.3.5.1-alpha~189 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ae35975402a823a420cd5efb81a1c3a76f6c4d6;p=thirdparty%2Ftor.git Tweak assertion in get_time_period_length() for coverity This is another attempt to fix 1437668. The assertion here should be safe, since the rules of networkstatus_get_param() keep the value it returns in range. --- diff --git a/src/feature/hs/hs_common.c b/src/feature/hs/hs_common.c index 328430be08..1c5dfd5e63 100644 --- a/src/feature/hs/hs_common.c +++ b/src/feature/hs/hs_common.c @@ -254,8 +254,8 @@ get_time_period_length(void) HS_TIME_PERIOD_LENGTH_MIN, HS_TIME_PERIOD_LENGTH_MAX); /* Make sure it's a positive value. */ - tor_assert(time_period_length >= 0); - /* uint64_t will always be able to contain a int32_t */ + tor_assert(time_period_length > 0); + /* uint64_t will always be able to contain a positive int32_t */ return (uint64_t) time_period_length; }