From: Byron Jones <bjones@mozilla.com>
Date: Tue, 17 Dec 2013 05:14:25 +0000 (+0800)
Subject: Bug 651786: Modifying the default user object modifies the DEFAULT_USER constant
X-Git-Tag: bugzilla-4.5.2~70
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ae8acb378094734fd000b82659350a3947ab413;p=thirdparty%2Fbugzilla.git

Bug 651786: Modifying the default user object modifies the DEFAULT_USER constant
r=sgreen, a=sgreen
---

diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 7a067fce0c..5c875918fb 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -23,7 +23,6 @@ use Bugzilla::Group;
 use DateTime::TimeZone;
 use List::Util qw(max);
 use Scalar::Util qw(blessed);
-use Storable qw(dclone);
 use URI;
 use URI::QueryParam;
 
@@ -118,7 +117,7 @@ sub new {
     my $class = ref($invocant) || $invocant;
     my ($param) = @_;
 
-    my $user = DEFAULT_USER;
+    my $user = { %{ DEFAULT_USER() } };
     bless ($user, $class);
     return $user unless $param;
 
@@ -136,7 +135,7 @@ sub super_user {
     my $class = ref($invocant) || $invocant;
     my ($param) = @_;
 
-    my $user = dclone(DEFAULT_USER);
+    my $user = { %{ DEFAULT_USER() } };
     $user->{groups} = [Bugzilla::Group->get_all];
     $user->{bless_groups} = [Bugzilla::Group->get_all];
     bless $user, $class;