From: liverpool1026 <liverpool1026.bne@gmail.com>
Date: Thu, 7 Oct 2021 19:46:58 +0000 (+1000)
Subject: Fix issue 928 create_check_constraint condition argument typing fix (#929)
X-Git-Tag: rel_1_7_5~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b01e5fa7178333f2e78ee0fc1322112307b51dd;p=thirdparty%2Fsqlalchemy%2Falembic.git

Fix issue 928 create_check_constraint condition argument typing fix (#929)

* Update create_check_constraint method typing

* Pass str type down

Fixes: #928

Co-authored-by: Kevin Hwa <liverpoo1026.bne@gmail.com>
Co-authored-by: Kevin Hwa <kevin.hwa@polymathian.com>
---

diff --git a/alembic/op.pyi b/alembic/op.pyi
index 2a03e1e2..d781ac1b 100644
--- a/alembic/op.pyi
+++ b/alembic/op.pyi
@@ -422,7 +422,7 @@ def bulk_insert(
 def create_check_constraint(
     constraint_name: Optional[str],
     table_name: str,
-    condition: "BinaryExpression",
+    condition: Union[str, "BinaryExpression"],
     schema: Optional[str] = None,
     **kw
 ) -> Optional["Table"]:
diff --git a/alembic/operations/ops.py b/alembic/operations/ops.py
index 7d69f093..99132dd6 100644
--- a/alembic/operations/ops.py
+++ b/alembic/operations/ops.py
@@ -732,7 +732,7 @@ class CreateCheckConstraintOp(AddConstraintOp):
         self,
         constraint_name: Optional[str],
         table_name: str,
-        condition: Union["TextClause", "ColumnElement[Any]"],
+        condition: Union[str, "TextClause", "ColumnElement[Any]"],
         schema: Optional[str] = None,
         **kw
     ) -> None:
@@ -778,7 +778,7 @@ class CreateCheckConstraintOp(AddConstraintOp):
         operations: "Operations",
         constraint_name: Optional[str],
         table_name: str,
-        condition: "BinaryExpression",
+        condition: Union[str, "BinaryExpression"],
         schema: Optional[str] = None,
         **kw
     ) -> Optional["Table"]:
diff --git a/alembic/operations/schemaobj.py b/alembic/operations/schemaobj.py
index 0d40dc78..3bff5083 100644
--- a/alembic/operations/schemaobj.py
+++ b/alembic/operations/schemaobj.py
@@ -137,7 +137,7 @@ class SchemaObjects:
         self,
         name: Optional[str],
         source: str,
-        condition: Union["TextClause", "ColumnElement[Any]"],
+        condition: Union[str, "TextClause", "ColumnElement[Any]"],
         schema: Optional[str] = None,
         **kw
     ) -> Union["CheckConstraint"]: