From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 1 Jul 2019 16:10:30 +0000 (+0200)
Subject: monitor: fix double cache update with --echo
X-Git-Tag: v0.9.2~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b032cd6477b;p=thirdparty%2Fnftables.git

monitor: fix double cache update with --echo

The evaluation step already updates the cache for each command in this
batch. There is no need to update the cache again from the echo path,
otherwise the cache is populated twice with the same object.

Fixes: b99c4d072d99 ("Implement --echo option")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/monitor.c b/src/monitor.c
index a68d960b..5b25c9d4 100644
--- a/src/monitor.c
+++ b/src/monitor.c
@@ -900,7 +900,6 @@ int netlink_echo_callback(const struct nlmsghdr *nlh, void *data)
 		.ctx = ctx,
 		.loc = &netlink_location,
 		.monitor_flags = 0xffffffff,
-		.cache_needed = true,
 	};
 
 	if (!nft_output_echo(&echo_monh.ctx->nft->output))