From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 14 Jun 2023 04:29:27 +0000 (+1200)
Subject: tests/auth_log: Refactor waitForMessages() to use nextMessage()
X-Git-Tag: talloc-2.4.1~374
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b0a71bd3085b7c67a72bf498870c69cf6b3baa5;p=thirdparty%2Fsamba.git

tests/auth_log: Refactor waitForMessages() to use nextMessage()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 14 23:55:42 UTC 2023 on atb-devel-224
---

diff --git a/python/samba/tests/auth_log_base.py b/python/samba/tests/auth_log_base.py
index c257f2fbafb..a9b2b3fa06b 100644
--- a/python/samba/tests/auth_log_base.py
+++ b/python/samba/tests/auth_log_base.py
@@ -113,23 +113,16 @@ class AuthLogTestBase(samba.tests.TestCase):
         until all the logging messages have been received.
         """
 
-        def completed(messages):
-            for message in messages:
-                if self.isRemote(message) and isLastExpectedMessage(message):
-                    return True
-            return False
-
-        self.connection = connection
-
-        start_time = time.time()
-        while not completed(self.context["messages"]):
-            self.msg_ctx.loop_once(0.1)
-            if time.time() - start_time > 1:
-                self.connection = None
+        messages = []
+        while True:
+            try:
+                msg = self.nextMessage()
+            except NoMessageException:
                 return []
 
-        self.connection = None
-        return list(filter(self.isRemote, self.context["messages"]))
+            messages.append(msg)
+            if isLastExpectedMessage(msg):
+                return messages
 
     def nextMessage(self, msgFilter=None):
         """Return the next relevant message, or throw a NoMessageException."""